Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: chrome/browser/usb/usb_chooser_bubble_delegate.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Move DCHECK string into longer comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_
6 #define CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_ 6 #define CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_
7 7
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 15 matching lines...) Expand all
26 class UsbDeviceFilter; 26 class UsbDeviceFilter;
27 } 27 }
28 28
29 class Browser; 29 class Browser;
30 30
31 // UsbChooserBubbleDelegate creates a chooser bubble for WebUsb. 31 // UsbChooserBubbleDelegate creates a chooser bubble for WebUsb.
32 class UsbChooserBubbleDelegate : public ChooserBubbleDelegate, 32 class UsbChooserBubbleDelegate : public ChooserBubbleDelegate,
33 public device::UsbService::Observer { 33 public device::UsbService::Observer {
34 public: 34 public:
35 UsbChooserBubbleDelegate( 35 UsbChooserBubbleDelegate(
36 Browser* browser, 36 content::RenderFrameHost* owner,
37 mojo::Array<device::usb::DeviceFilterPtr> device_filters, 37 mojo::Array<device::usb::DeviceFilterPtr> device_filters,
38 content::RenderFrameHost* render_frame_host, 38 content::RenderFrameHost* render_frame_host,
39 const webusb::WebUsbPermissionBubble::GetPermissionCallback& callback); 39 const webusb::WebUsbPermissionBubble::GetPermissionCallback& callback);
40 ~UsbChooserBubbleDelegate() override; 40 ~UsbChooserBubbleDelegate() override;
41 41
42 // ChooserBubbleDelegate: 42 // ChooserBubbleDelegate:
43 size_t NumOptions() const override; 43 size_t NumOptions() const override;
44 const base::string16& GetOption(size_t index) const override; 44 const base::string16& GetOption(size_t index) const override;
45 void Select(size_t index) override; 45 void Select(size_t index) override;
46 void Cancel() override; 46 void Cancel() override;
(...skipping 17 matching lines...) Expand all
64 // Each pair is a (device, device name). 64 // Each pair is a (device, device name).
65 std::vector<std::pair<scoped_refptr<device::UsbDevice>, base::string16>> 65 std::vector<std::pair<scoped_refptr<device::UsbDevice>, base::string16>>
66 devices_; 66 devices_;
67 BubbleReference bubble_controller_; 67 BubbleReference bubble_controller_;
68 base::WeakPtrFactory<UsbChooserBubbleDelegate> weak_factory_; 68 base::WeakPtrFactory<UsbChooserBubbleDelegate> weak_factory_;
69 69
70 DISALLOW_COPY_AND_ASSIGN(UsbChooserBubbleDelegate); 70 DISALLOW_COPY_AND_ASSIGN(UsbChooserBubbleDelegate);
71 }; 71 };
72 72
73 #endif // CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_ 73 #endif // CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/website_settings/chooser_bubble_delegate.cc ('k') | chrome/browser/usb/usb_chooser_bubble_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698