Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: chrome/browser/ui/chrome_bubble_manager.h

Issue 1572743002: Make sure bubbles in Views default to close before their RenderFrameHosts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_ 5 #ifndef CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
6 #define CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_ 6 #define CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h" 9 #include "chrome/browser/ui/tabs/tab_strip_model_observer.h"
10 #include "components/bubble/bubble_manager.h" 10 #include "components/bubble/bubble_manager.h"
(...skipping 10 matching lines...) Expand all
21 21
22 // TabStripModelObserver: 22 // TabStripModelObserver:
23 void TabDetachedAt(content::WebContents* contents, int index) override; 23 void TabDetachedAt(content::WebContents* contents, int index) override;
24 void TabDeactivated(content::WebContents* contents) override; 24 void TabDeactivated(content::WebContents* contents) override;
25 void ActiveTabChanged(content::WebContents* old_contents, 25 void ActiveTabChanged(content::WebContents* old_contents,
26 content::WebContents* new_contents, 26 content::WebContents* new_contents,
27 int index, 27 int index,
28 int reason) override; 28 int reason) override;
29 29
30 // content::WebContentsObserver: 30 // content::WebContentsObserver:
31 void FrameDeleted(content::RenderFrameHost* render_frame_host) override;
31 void DidToggleFullscreenModeForTab(bool entered_fullscreen) override; 32 void DidToggleFullscreenModeForTab(bool entered_fullscreen) override;
32 void NavigationEntryCommitted( 33 void NavigationEntryCommitted(
33 const content::LoadCommittedDetails& load_details) override; 34 const content::LoadCommittedDetails& load_details) override;
34 35
35 private: 36 private:
36 class ChromeBubbleMetrics : public BubbleManager::BubbleManagerObserver { 37 class ChromeBubbleMetrics : public BubbleManager::BubbleManagerObserver {
37 public: 38 public:
38 ChromeBubbleMetrics() {} 39 ChromeBubbleMetrics() {}
39 ~ChromeBubbleMetrics() override {} 40 ~ChromeBubbleMetrics() override {}
40 41
41 // BubbleManager::BubbleManagerObserver: 42 // BubbleManager::BubbleManagerObserver:
42 void OnBubbleNeverShown(BubbleReference bubble) override; 43 void OnBubbleNeverShown(BubbleReference bubble) override;
43 void OnBubbleClosed(BubbleReference bubble, 44 void OnBubbleClosed(BubbleReference bubble,
44 BubbleCloseReason reason) override; 45 BubbleCloseReason reason) override;
45 46
46 private: 47 private:
47 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleMetrics); 48 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleMetrics);
48 }; 49 };
49 50
50 TabStripModel* tab_strip_model_; 51 TabStripModel* tab_strip_model_;
51 ChromeBubbleMetrics chrome_bubble_metrics_; 52 ChromeBubbleMetrics chrome_bubble_metrics_;
52 53
53 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleManager); 54 DISALLOW_COPY_AND_ASSIGN(ChromeBubbleManager);
54 }; 55 };
55 56
56 #endif // CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_ 57 #endif // CHROME_BROWSER_UI_CHROME_BUBBLE_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/chrome_bubble_manager.cc » ('j') | components/bubble/bubble_close_reason.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698