Issue 157273005: Fix potential crash causes in ServiceWorker LayoutTests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 157273005: Fix potential crash causes in ServiceWorker LayoutTests (Closed)

Created:
6 years, 10 months ago by kinuko

Modified:
6 years, 10 months ago

Reviewers:
alecflett

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix potential crash causes in ServiceWorker LayoutTests 1. Adds an empty serviceworker.js Registering nonexistent worker script will start to return InstallError, so create an empty serviceworker.js in the LayoutTests (we should also add nonexistent worker case once the registration patch re-lands) 2. Handle all possible error cases in ServiceWorkerError.cpp Getting an error other than DisabledError hits ASSERT in debug build, so handle other error cases too. BUG=285976 TEST=virtual/serviceworker/http/tests/serviceworker/registration.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166739

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	A	LayoutTests/http/tests/serviceworker/serviceworker.js	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	Source/modules/serviceworkers/ServiceWorkerError.cpp	View		1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kinuko

Alec, can you review this (and click CQ if it looks good to you)? This ...

6 years, 10 months ago (2014-02-07 13:47:06 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/157273005/50001

6 years, 10 months ago (2014-02-07 18:53:49 UTC) #3

Message was sent while issue was closed.

Change committed as 166739

Expand Messages | Collapse Messages