Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: build/config/android/config.gni

Issue 157273002: GN: Remove android arguments from the conditional (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/config.gni
diff --git a/build/config/android/config.gni b/build/config/android/config.gni
index 9fc6c27d0de4676d0517c1a0cdabb6295d312352..c7408127276ec6fa8723c82f74d4fc6a5aeda701 100644
--- a/build/config/android/config.gni
+++ b/build/config/android/config.gni
@@ -3,16 +3,21 @@
# found in the LICENSE file.
# This file contains common system config stuff for the Android build.
-if (is_android) {
- declare_args() {
- android_src = ""
- # This is set when building the Android WebView inside the Android build
- # system, using the 'android' gyp backend. The WebView code is still built
- # when this is unset, but builds using the normal chromium build system.
- is_android_webview_build = false
- }
+# TODO(brettw) bug 341772 put this into the is_android block when the toolchain
+# stuff is fixed in the GYP generator. The problem is that when we redo the
+# build in host mode, the OS is not android and the declarations are never
+# seen, which throws an error because these arguments are specified.
+declare_args() {
+ android_src = ""
+ # This is set when building the Android WebView inside the Android build
+ # system, using the 'android' gyp backend. The WebView code is still built
+ # when this is unset, but builds using the normal chromium build system.
+ is_android_webview_build = false
+}
+
+if (is_android) {
if (is_android_webview_build) {
assert(android_src != "",
"You must specify android_src for an Android WebView build.")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698