Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1572673005: dart2js: Fix build. (Closed)

Created:
4 years, 11 months ago by Kevin Millikin (Google)
Modified:
4 years, 11 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Fix build. When moving code, I forgot to change a parameter type. This triggered a warning. TBR=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/aa21250b7a7ef7ab0b1900dbee89f1abf2c5b684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Kevin Millikin (Google)
TBR'd.
4 years, 11 months ago (2016-01-09 01:38:22 UTC) #1
Kevin Millikin (Google)
Committed patchset #1 (id:1) manually as aa21250b7a7ef7ab0b1900dbee89f1abf2c5b684 (presubmit successful).
4 years, 11 months ago (2016-01-09 01:38:42 UTC) #3
asgerf
4 years, 11 months ago (2016-01-11 16:15:01 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698