Add --zero_init to simulate zero-initialized memory in CodecBench

Add --zero_init to simulate zero-initialized memory in CodecBench

BUG=skia:4767
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1572673004

Committed: https://skia.googlesource.com/skia/+/c146aa6fd45dffe29b4f565aafd4ec3a16d9f73b

[mtklein_C, 2016-01-08 21:54:06]

Description was changed from

==========
Add --zero_init to simulate zero-initialized memory in CodecBench

BUG=skia:4767
==========

to

==========
Add --zero_init to simulate zero-initialized memory in CodecBench

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-08 21:54:40]

mtklein@chromium.org changed reviewers:
+ msarett@google.com, scroggo@google.com

[msarett, 2016-01-08 21:59:41]

LGTM

You seem to always be a few steps ahead of me :)

https://codereview.chromium.org/1572673004/diff/1/bench/CodecBench.cpp
File bench/CodecBench.cpp (right):

https://codereview.chromium.org/1572673004/diff/1/bench/CodecBench.cpp#newcode57
bench/CodecBench.cpp:57: SkCodec::Options options;
Can we add this code outside of the loop?  I bet the compile hoists it, but it
would make me happier.

[mtklein_C, 2016-01-08 22:03:37]

When I WFH, I get to type louder, and so faster, than when I WFW.

https://codereview.chromium.org/1572673004/diff/1/bench/CodecBench.cpp
File bench/CodecBench.cpp (right):

https://codereview.chromium.org/1572673004/diff/1/bench/CodecBench.cpp#newcode57
bench/CodecBench.cpp:57: SkCodec::Options options;
On 2016/01/08 at 21:59:41, msarett wrote:
> Can we add this code outside of the loop?  I bet the compile hoists it, but it
would make me happier.
Done.

[mtklein_C, 2016-01-08 22:03:45]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-01-08 22:03:45]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com
Link to the patchset: https://codereview.chromium.org/1572673004/#ps20001
(title: "hoist")

[commit-bot: I haz the power, 2016-01-08 22:03:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572673004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572673004/20001

[scroggo, 2016-01-08 22:20:29]

lgtm

https://codereview.chromium.org/1572673004/diff/20001/bench/CodecBench.cpp
File bench/CodecBench.cpp (right):

https://codereview.chromium.org/1572673004/diff/20001/bench/CodecBench.cpp#ne...
bench/CodecBench.cpp:16: DEFINE_bool(zero_init, false, "Pretend our destination
is zero-intialized, simulating Android?");
Hahaha - we could also add this as another option in our matrix of tests, along
with config etc.

[commit-bot: I haz the power, 2016-01-08 22:20:38]

Description was changed from

==========
Add --zero_init to simulate zero-initialized memory in CodecBench

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add --zero_init to simulate zero-initialized memory in CodecBench

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/c146aa6fd45dffe29b4f565aafd4ec3a16d9f73b
==========

[commit-bot: I haz the power, 2016-01-08 22:20:39]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c146aa6fd45dffe29b4f565aafd4ec3a16d9f73b

[mtklein, 2016-01-08 22:21:46]

On 2016/01/08 22:20:29, scroggo wrote:
> lgtm
> 
> https://codereview.chromium.org/1572673004/diff/20001/bench/CodecBench.cpp
> File bench/CodecBench.cpp (right):
> 
>
https://codereview.chromium.org/1572673004/diff/20001/bench/CodecBench.cpp#ne...
> bench/CodecBench.cpp:16: DEFINE_bool(zero_init, false, "Pretend our
destination
> is zero-intialized, simulating Android?");
> Hahaha - we could also add this as another option in our matrix of tests,
along
> with config etc.

One thing at a time.  That matrix is already quite hyper-dimensional. :)