Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1572653002: Reland of Make a single GrSingleOwner in GrContext (Closed)

Created:
4 years, 11 months ago by joshualitt
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of Make a single GrSingleOwner in GrContext (patchset #1 id:1 of https://codereview.chromium.org/1565303003/ ) Reason for revert: trying again Original issue's description: > Revert of Make a single GrSingleOwner in GrContext (patchset #3 id:40001 of https://codereview.chromium.org/1563703004/ ) > > Reason for revert: > breaking asan > > Original issue's description: > > Make a single GrSingleOwner in GrContext > > > > TBR=bsalomon@google.com > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1563703004 > > > > Committed: https://skia.googlesource.com/skia/+/f9bc796e0dbd31674c22b34761913ee6e8fdd66a > > TBR=robertphillips@google.com,joshualitt@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/94da292e39db0d41da08b1d6055ca5e0d6b498cc TBR=robertphillips@google.com,joshualitt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/de8dc7e9201a14759076ea4090bdf8a54791817b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M include/gpu/GrContext.h View 1 chunk +3 lines, -1 line 0 comments Download
M include/gpu/GrDrawContext.h View 2 chunks +3 lines, -2 lines 0 comments Download
M include/private/GrSingleOwner.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawContext.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
joshualitt
Created Reland of Make a single GrSingleOwner in GrContext
4 years, 11 months ago (2016-01-08 18:09:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1572653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1572653002/1
4 years, 11 months ago (2016-01-08 18:09:09 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 18:09:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/de8dc7e9201a14759076ea4090bdf8a54791817b

Powered by Google App Engine
This is Rietveld 408576698