Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1572523002: XFA: Remove relative includes outside of xfa/. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -80 lines) Patch
M core/src/fxcodec/codec/fx_codec_bmp.cpp View 1 chunk +3 lines, -3 lines 4 comments Download
M core/src/fxcodec/codec/fx_codec_gif.cpp View 1 chunk +3 lines, -3 lines 2 comments Download
M core/src/fxcodec/codec/fx_codec_png.cpp View 1 chunk +2 lines, -2 lines 1 comment Download
M core/src/fxcodec/codec/fx_codec_progress.cpp View 1 chunk +2 lines, -2 lines 1 comment Download
M core/src/fxcodec/codec/fx_codec_tiff.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/lbmp/fx_bmp.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/lgif/fx_gif.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_arabic.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_arabic.cpp View 1 chunk +1 line, -1 line 2 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_app.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fpdfxfa/fpdfxfa_doc.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_define.h View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfeditpage.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfformfill.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfsave.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdftext.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/fpdfxfa/fpdfxfa_util.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/fsdk_annothandler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/libtiff/0000-build-config.patch View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/libtiff/tiffconf.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
4 years, 11 months ago (2016-01-08 08:03:30 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1572523002/diff/1/core/src/fxcodec/codec/fx_codec_bmp.cpp File core/src/fxcodec/codec/fx_codec_bmp.cpp (right): https://codereview.chromium.org/1572523002/diff/1/core/src/fxcodec/codec/fx_codec_bmp.cpp#newcode9 core/src/fxcodec/codec/fx_codec_bmp.cpp:9: #include "codec_int.h" nit: full path here while you're ...
4 years, 11 months ago (2016-01-08 18:07:18 UTC) #3
Lei Zhang
https://codereview.chromium.org/1572523002/diff/1/core/src/fxcodec/codec/fx_codec_bmp.cpp File core/src/fxcodec/codec/fx_codec_bmp.cpp (right): https://codereview.chromium.org/1572523002/diff/1/core/src/fxcodec/codec/fx_codec_bmp.cpp#newcode9 core/src/fxcodec/codec/fx_codec_bmp.cpp:9: #include "codec_int.h" On 2016/01/08 18:07:18, Tom Sepez wrote: > ...
4 years, 11 months ago (2016-01-08 21:51:00 UTC) #4
Lei Zhang
4 years, 11 months ago (2016-01-08 21:51:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
875b9c99efdbd5fcabf0213e0d392cb2876ed26a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698