Fix bug in SsaConstructionFieldTypes: handle mulitple assignments to the same field.

sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 abstract class OptimizationPhase {
   String get name;
   void visitGraph(HGraph graph);
 }
@@ skipping 1447 matching lines @@
           j++;
         },
         includeSuperAndInjectedMembers: true);
   }
 
   visitFieldSet(HFieldSet node) {
     Element field = node.element;
     HInstruction value = node.value;
     HType type = value.instructionType;
     // [HFieldSet] is also used for variables in try/catch.
-    if (field.isField()) allSetters.add(field);
+    if (!field.isField()) return;
+    allSetters.add(field);
     // Don't handle fields defined in superclasses. Given that the field is
     // always added to the [allSetters] set, setting a field defined in a
     // superclass will get an inferred type of UNKNOWN.
-    if (identical(work.element.getEnclosingClass(), field.getEnclosingClass()) &&
-        !value.instructionType.isUnknown()) {
-      currentFieldSetters[field] = type;
+    if (work.element.getEnclosingClass() == field.getEnclosingClass()) {
+      HType existing = currentFieldSetters[field];
+      // If we have seen an assignment already, we check if
+      // it's of the same type. If it's not, we remove the current
+      // field type information.
+      if (existing != null) {
+        if (existing == type) {
+          return;
+        } else {
+          currentFieldSetters.remove(field);

[kasperl, 2013/06/06 08:15:12]

Can we then get another field type added after this? Should we add a marker
instead of removing it? Need a test with three field sets?

[ngeoffray, 2013/06/06 08:44:00]

Good catch. Done.

+        }
+      } else if (!type.isUnknown()) {
+        currentFieldSetters[field] = type;
+      }
     }
   }
 
   visitExit(HExit node) {
     // If this has been exposed then we cannot say anything about types after
     // construction.
     if (!thisExposed) {
       // Register the known field types.
       currentFieldSetters.forEach((Element element, HType type) {
         backend.registerFieldConstructor(element, type);
         allSetters.remove(element);
       });
     }
 
     // For other fields having setters in the generative constructor body, set
     // the type to UNKNOWN to avoid relying on the type set in the initializer
     // list.
     allSetters.forEach((Element element) {
       backend.registerFieldConstructor(element, HType.UNKNOWN);
     });
   }
 }