Source/core/platform/ScrollableArea.h - Issue 15725009: Should be able to scroll text in <input> fields with touch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/ScrollableArea.h

Issue 15725009: Should be able to scroll text in <input> fields with touch (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Cleanup from initial CR Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-text-field-expected.txt ('k') | Source/core/platform/ScrollableArea.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/platform/ScrollableArea.h

diff --git a/Source/core/platform/ScrollableArea.h b/Source/core/platform/ScrollableArea.h

index 4b0b7b6654f9b27757e0a1910e78b97ba03960b0..4ed977e3438ce9722e4e71f275e41c28e7ae186e 100644

--- a/Source/core/platform/ScrollableArea.h

+++ b/Source/core/platform/ScrollableArea.h

@@ -40,6 +40,9 @@ class ScrollAnimator;

class ScrollableArea {

public:

+ // Allow the ScrollableArea to be scrolled when we don't have scrollbars (i.e. for an input text field)

+ bool touchScroll(ScrollDirection, ScrollGranularity, float multiplier = 1);

bool scroll(ScrollDirection, ScrollGranularity, float multiplier = 1);

void scrollToOffsetWithoutAnimation(const FloatPoint&);

void scrollToOffsetWithoutAnimation(ScrollbarOrientation, float offset);