Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: Source/core/rendering/RenderLayer.cpp

Issue 15725009: Should be able to scroll text in <input> fields with touch (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/rendering/RenderBox.h ('K') | « Source/core/rendering/RenderBox.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderLayer.cpp
diff --git a/Source/core/rendering/RenderLayer.cpp b/Source/core/rendering/RenderLayer.cpp
index 17edf636a3a2c9e7116f6987e2195b220b1c5311..56f41cd8414b155651e567c4e0a50106ad2d09d0 100644
--- a/Source/core/rendering/RenderLayer.cpp
+++ b/Source/core/rendering/RenderLayer.cpp
@@ -3116,7 +3116,8 @@ void RenderLayer::computeScrollDimensions()
bool RenderLayer::hasScrollableHorizontalOverflow() const
{
- return hasHorizontalOverflow() && renderBox()->scrollsOverflowX();
+ return hasHorizontalOverflow()
+ && (renderBox()->scrollsOverflowX() || renderBox()->isScrollableWithoutScrollbars());
}
bool RenderLayer::hasScrollableVerticalOverflow() const
@@ -3473,6 +3474,10 @@ bool RenderLayer::hitTestOverflowControls(HitTestResult& result, const IntPoint&
bool RenderLayer::scroll(ScrollDirection direction, ScrollGranularity granularity, float multiplier)
{
+ // Some elements can be touch scrolled even in the absence of scrollbars (e.g. <input> textfield)
+ if (renderBox()->isScrollableWithoutScrollbars())
+ return touchScroll(direction, granularity, multiplier);
bokan 2013/05/30 18:23:51 Moved this call into RenderTextControlSingleLine::
+
return ScrollableArea::scroll(direction, granularity, multiplier);
}
« Source/core/rendering/RenderBox.h ('K') | « Source/core/rendering/RenderBox.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698