Enable pre-connect via {mouse,gesture}-event triggers to limited users controlled by Finch.

Enable pre-connect via {mouse,gesture}-event triggers to limited users controlled by Finch.

BUG=240959
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203120

[kouhei (in TOK), 2013-05-27 07:52:04]

jam, mathp: Would you take a look?

[Mathieu, 2013-05-27 12:34:53]

Finch trial code lgtm

https://codereview.chromium.org/15725006/diff/1/chrome/renderer/net/prescient...
File chrome/renderer/net/prescient_networking_dispatcher.cc (right):

https://codereview.chromium.org/15725006/diff/1/chrome/renderer/net/prescient...
chrome/renderer/net/prescient_networking_dispatcher.cc:21: 
Document the function?

https://codereview.chromium.org/15725006/diff/1/chrome/renderer/net/prescient...
chrome/renderer/net/prescient_networking_dispatcher.cc:41: }
nit: // end namespace

[Mathieu, 2013-05-27 12:50:47]

https://codereview.chromium.org/15725006/diff/1/chrome/renderer/net/prescient...
File chrome/renderer/net/prescient_networking_dispatcher.cc (right):

https://codereview.chromium.org/15725006/diff/1/chrome/renderer/net/prescient...
chrome/renderer/net/prescient_networking_dispatcher.cc:41: }
On 2013/05/27 12:34:53, Mathieu Perreault wrote:
> nit: // end namespace

or rather // namespace, sorry

[kouhei (in TOK), 2013-05-28 03:09:00]

mathp: Thanks for review!

jam: Would you take a look?

https://codereview.chromium.org/15725006/diff/1/chrome/renderer/net/prescient...
File chrome/renderer/net/prescient_networking_dispatcher.cc (right):

https://codereview.chromium.org/15725006/diff/1/chrome/renderer/net/prescient...
chrome/renderer/net/prescient_networking_dispatcher.cc:21: 
On 2013/05/27 12:34:53, Mathieu Perreault wrote:
> Document the function?

Done.

https://codereview.chromium.org/15725006/diff/1/chrome/renderer/net/prescient...
chrome/renderer/net/prescient_networking_dispatcher.cc:41: }
On 2013/05/27 12:50:48, Mathieu Perreault wrote:
> On 2013/05/27 12:34:53, Mathieu Perreault wrote:
> > nit: // end namespace
> 
> or rather // namespace, sorry

Done.

[jam, 2013-05-28 15:57:59]

On 2013/05/28 03:09:00, kouhei wrote:
> mathp: Thanks for review!
> 
> jam: Would you take a look?
please see the comment in chrome/OWNERS

[kouhei (in TOK), 2013-05-30 00:19:17]

thakis: Would you review this patch?

[Nico, 2013-05-30 00:26:23]

lgtm; optional nit below

https://codereview.chromium.org/15725006/diff/6001/chrome/renderer/net/presci...
File chrome/renderer/net/prescient_networking_dispatcher.cc (right):

https://codereview.chromium.org/15725006/diff/6001/chrome/renderer/net/presci...
chrome/renderer/net/prescient_networking_dispatcher.cc:56:
content::RenderThread::Get()->Send(new ChromeViewHostMsg_Preconnect(url));
If it fits in 80 cols, write

  if (isPrec…)
    RenderThread...->Send(…)

instead of the early return (unless you plan on adding more code down here)

[kouhei (in TOK), 2013-05-30 00:30:35]

Thanks for quick review!

https://codereview.chromium.org/15725006/diff/6001/chrome/renderer/net/presci...
File chrome/renderer/net/prescient_networking_dispatcher.cc (right):

https://codereview.chromium.org/15725006/diff/6001/chrome/renderer/net/presci...
chrome/renderer/net/prescient_networking_dispatcher.cc:56:
content::RenderThread::Get()->Send(new ChromeViewHostMsg_Preconnect(url));
On 2013/05/30 00:26:23, Nico wrote:
> If it fits in 80 cols, write
> 
>   if (isPrec…)
>     RenderThread...->Send(…)
> 
> instead of the early return (unless you plan on adding more code down here)

Done.

[commit-bot: I haz the power, 2013-05-30 00:31:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/15725006/13001

[commit-bot: I haz the power, 2013-05-30 01:09:12]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_aura.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-30 01:11:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/15725006/13001

[commit-bot: I haz the power, 2013-05-30 01:24:56]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-30 05:19:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/15725006/13001

[commit-bot: I haz the power, 2013-05-30 08:12:28]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-30 08:49:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kouhei@chromium.org/15725006/13001

[commit-bot: I haz the power, 2013-05-30 12:18:10]

Change committed as 203120

[kouhei (in TOK), 2013-06-26 04:52:44]

On 2013/05/30 12:18:10, I haz the power (commit-bot) wrote:
> Change committed as 203120

It turned out that this patch was incomplete. Trying to fix the bug in
http://crrev.com/17749008