Implement OnGetNetworks for net.mojom

components/arc/arc_service_manager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_ARC_ARC_SERVICE_MANAGER_H_
 #define COMPONENTS_ARC_ARC_SERVICE_MANAGER_H_
 
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/threading/thread_checker.h"
+#include "components/arc/common/net.mojom.h"
 
 namespace arc {
 
 class ArcAuthService;
 class ArcBridgeService;
 class ArcClipboardBridge;
 class ArcInputBridge;
+class ArcNetHostImpl;
 class ArcSettingsBridge;
 class ArcPowerBridge;
 
 // Manages creation and destruction of services that communicate with the ARC
 // instance via the ArcBridgeService.
 class ArcServiceManager {
  public:
   ArcServiceManager(scoped_ptr<ArcAuthService> auth_service,
                     scoped_ptr<ArcSettingsBridge> settings_bridge);
   virtual ~ArcServiceManager();
 
   // |arc_bridge_service| can only be accessed on the thread that this
   // class was created on.
   ArcBridgeService* arc_bridge_service();
 
   // Gets the global instance of the ARC Service Manager. This can only be
   // called on the thread that this class was created on.
   static ArcServiceManager* Get();
 
  private:
   base::ThreadChecker thread_checker_;
   scoped_ptr<ArcBridgeService> arc_bridge_service_;
 
   // Individual services
   scoped_ptr<ArcAuthService> arc_auth_service_;
   scoped_ptr<ArcClipboardBridge> arc_clipboard_bridge_;
   scoped_ptr<ArcInputBridge> arc_input_bridge_;
+  scoped_ptr<arc::NetHost> arc_net_host_;

[abhishekbh, 2016/01/12 22:42:26]

should this be ArcNetHostImpl ?

[Kevin Cernekee, 2016/01/12 23:53:27]

Per lhchavez we were able to bypass some of the indirection layers that the
other calls are using, because we don't have to call into certain parts of
Chrome.

(Sorry but I'm a little sketchy on the details - Luis could provide a much
better explanation than I can.)

[Luis Héctor Chávez, 2016/01/12 23:57:20]

Some of the other services require to use this indirection since they are
instantiated elsewhere (typically in ChromeBrowserMain), but the ownership is
then transferred to the ArcServiceManager. The reason they are instantiated
there is that they depend on directories that code in components/arc/ is now
allowed to depend on (like chrome/ or content/). The current net implementation
does not fall into that category IIUC, so we should be able to use the concrete
class here.

[hidehiko, 2016/01/13 05:58:56]

nit: here in arc:: namespace.

   scoped_ptr<ArcSettingsBridge> arc_settings_bridge_;
   scoped_ptr<ArcPowerBridge> arc_power_bridge_;
 
   DISALLOW_COPY_AND_ASSIGN(ArcServiceManager);
 };
 
 }  // namespace arc
 
 #endif  // COMPONENTS_ARC_ARC_SERVICE_MANAGER_H_