cpsir: fix co19 test - use process* instead of visit* (we unadvertly removed code that recursed int…

pkg/compiler/lib/src/cps_ir/insert_refinements.dart

Index: pkg/compiler/lib/src/cps_ir/insert_refinements.dart
diff --git a/pkg/compiler/lib/src/cps_ir/insert_refinements.dart b/pkg/compiler/lib/src/cps_ir/insert_refinements.dart
index e2e6b849c70c8a271a1815f844913833b4cf97b5..c67048521c910e1a1cbcd6fd7ffbca8144b9295b 100644
--- a/pkg/compiler/lib/src/cps_ir/insert_refinements.dart
+++ b/pkg/compiler/lib/src/cps_ir/insert_refinements.dart
@@ -127,7 +127,7 @@ class InsertRefinements extends TrampolineRecursiveVisitor implements Pass {
     }
   }
 
-  void visitInvokeStatic(InvokeStatic node) {
+  void processInvokeStatic(InvokeStatic node) {

[asgerf, 2016/01/11 21:35:06]

Please do like in visitInvokeMethod and visitTypeTest, call the processReference
method explicitly.

processInvokeStatic is called before its operands are processed, which is the
wrong order for this pass.

Now we will be updating the refinement environment before visiting the
references so the invoke will end up seeing its own refined values. That is, we
will get code like:

x' = refine(x, int)
InvokeStatic checkInt (x')

Instead of:

InvokeStatic checkInt (x)
x' = refine(x, int)


It seems strange that this would make the test pass. Maybe it passed for the
wrong reason in the first place?

[Siggi Cherem (dart-lang), 2016/01/11 21:51:09]

good catch! Done.

Before I sent this I haven't yet run all the other test, just the co19 test that
failed on the bots. Turns out that the unittest for static methods did caught
this and shows exactly the issue you mention.

The co19 test was failing only because I was overriding visitInvokeStatic
without visiting the arguments entirely.

     _refineArguments(node,
         _getSuccessTypesForStaticMethod(types, node.target));
   }