Vibration API: use runtime flag, change from client to platform.

Source/modules/vibration/Vibration.h

Index: Source/modules/vibration/Vibration.h
diff --git a/Source/modules/vibration/Vibration.h b/Source/modules/vibration/Vibration.h
index 1514f15c89b5cea9743fa740080f2698b9add695..035d8247dff098af32a4a779a6aca45b49c66022 100644
--- a/Source/modules/vibration/Vibration.h
+++ b/Source/modules/vibration/Vibration.h
@@ -20,25 +20,18 @@
 #ifndef Vibration_h
 #define Vibration_h
 
-#if ENABLE(VIBRATION)
-
 #include "core/page/Page.h"
 #include "core/platform/Timer.h"
 #include "wtf/PassOwnPtr.h"
 
 namespace WebCore {
 
-class VibrationClient;
-
 class Vibration : public Supplement<Page> {

[abarth-chromium, 2013/06/11 23:57:31]

What's the point of having a separate Vibration page supplement?  It seems like
you could do all this work in NavigatorVibration if you made that object a
Supplement<Navigator>.

[Michael van Ouwerkerk, 2013/06/12 16:44:50]

You're right, so: done! I was trying to keep this patch small but I understand
now that this code was ripe for a full review. I've rearranged most of it and
updated the algorithm and interface to adhere better to the latest version of
the editor's draft.

 public:
     typedef Vector<unsigned> VibrationPattern;
 
-    explicit Vibration(VibrationClient*);
     ~Vibration();
 
-    static PassOwnPtr<Vibration> create(VibrationClient*);
-
     void vibrate(const unsigned& time);
     void vibrate(const VibrationPattern&);
     void cancelVibration();
@@ -49,12 +42,12 @@ public:
     void timerStartFired(Timer<Vibration>*);
     void timerStopFired(Timer<Vibration>*);
 
-    static const char* supplementName();
-    static Vibration* from(Page* page) { return static_cast<Vibration*>(Supplement<Page>::from(page, supplementName())); }
-    static bool isActive(Page*);
+    static Vibration* from(Page*);
 
 private:
-    VibrationClient* m_vibrationClient;
+    Vibration();
+    static const char* supplementName();
+
     Timer<Vibration> m_timerStart;
     Timer<Vibration> m_timerStop;
     bool m_isVibrating;
@@ -63,7 +56,4 @@ private:
 
 } // namespace WebCore
 
-#endif // ENABLE(VIBRATION)
-
 #endif // Vibration_h
-