Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1932)

Unified Diff: Source/modules/vibration/NavigatorVibration.cpp

Issue 15724023: Vibration API: use runtime flag, change from client to platform. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/vibration/NavigatorVibration.cpp
diff --git a/Source/modules/vibration/NavigatorVibration.cpp b/Source/modules/vibration/NavigatorVibration.cpp
index 4e9889d56f93dc41e2f93d2260ad390c1d38d247..9dbe3e23db2f982030b23dcc311a49198987563a 100644
--- a/Source/modules/vibration/NavigatorVibration.cpp
+++ b/Source/modules/vibration/NavigatorVibration.cpp
@@ -20,8 +20,6 @@
#include "config.h"
#include "modules/vibration/NavigatorVibration.h"
-#if ENABLE(VIBRATION)
-
#include "core/dom/ExceptionCode.h"
#include "core/page/Frame.h"
#include "core/page/Navigator.h"
@@ -47,10 +45,8 @@ void NavigatorVibration::vibrate(Navigator* navigator, unsigned time, ExceptionC
if (navigator->frame()->page()->visibilityState() == PageVisibilityStateHidden)
return;
- if (!Vibration::isActive(navigator->frame()->page())) {
- ec = NOT_SUPPORTED_ERR;
- return;
- }
+ if (!Vibration::isActive(navigator->frame()->page()))
+ provideVibrationTo(navigator->frame()->page());
Peter Beverloo 2013/06/11 10:19:10 navigator->frame()->page() is used five times in t
Michael van Ouwerkerk 2013/06/11 13:26:51 Done.
Vibration::from(navigator->frame()->page())->vibrate(time);
}
@@ -63,15 +59,10 @@ void NavigatorVibration::vibrate(Navigator* navigator, const VibrationPattern& p
if (navigator->frame()->page()->visibilityState() == PageVisibilityStateHidden)
return;
- if (!Vibration::isActive(navigator->frame()->page())) {
- ec = NOT_SUPPORTED_ERR;
- return;
- }
+ if (!Vibration::isActive(navigator->frame()->page()))
+ provideVibrationTo(navigator->frame()->page());
Peter Beverloo 2013/06/11 10:19:10 dito
Michael van Ouwerkerk 2013/06/11 13:26:51 Done.
Vibration::from(navigator->frame()->page())->vibrate(pattern);
}
} // namespace WebCore
-
-#endif // ENABLE(VIBRATION)
-

Powered by Google App Engine
This is Rietveld 408576698