Vibration API: use runtime flag, change from client to platform.

Source/modules/vibration/NavigatorVibration.cpp

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  *  Library General Public License for more details.
  *
  *  You should have received a copy of the GNU Library General Public License
  *  along with this library; see the file COPYING.LIB.  If not, write to
  *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  *  Boston, MA 02110-1301, USA.
  */
 
 #include "config.h"
 #include "modules/vibration/NavigatorVibration.h"
 
-#if ENABLE(VIBRATION)
-
-#include "core/dom/ExceptionCode.h"
 #include "core/page/Frame.h"
 #include "core/page/Navigator.h"
 #include "core/page/Page.h"
 #include "modules/vibration/Vibration.h"
 #include "wtf/Uint32Array.h"
 
 namespace WebCore {
 
-NavigatorVibration::NavigatorVibration()
+void NavigatorVibration::vibrate(Navigator* navigator, unsigned time)
 {
+    Page* page = navigator->frame()->page();
+
+    if (!page)
+        return;
+
+    if (page->visibilityState() == PageVisibilityStateHidden)
+        return;
+
+    Vibration::from(page)->vibrate(time);
 }
 
-NavigatorVibration::~NavigatorVibration()
+void NavigatorVibration::vibrate(Navigator* navigator, const VibrationPattern& pattern)
 {
-}
+    Page* page = navigator->frame()->page();
 
-void NavigatorVibration::vibrate(Navigator* navigator, unsigned time, ExceptionCode& ec)
-{
-    if (!navigator->frame()->page())
+    if (!page)
         return;
 
-    if (navigator->frame()->page()->visibilityState() == PageVisibilityStateHidden)
+    if (page->visibilityState() == PageVisibilityStateHidden)
         return;

[abarth-chromium, 2013/06/11 23:55:36]

Can you extract this copy/paste code into a helper function?

[Michael van Ouwerkerk, 2013/06/12 16:44:50]

I've changed it so the one vibrate method calls the other.

 
-    if (!Vibration::isActive(navigator->frame()->page())) {
-        ec = NOT_SUPPORTED_ERR;
-        return;
-    }
-
-    Vibration::from(navigator->frame()->page())->vibrate(time);
-}
-
-void NavigatorVibration::vibrate(Navigator* navigator, const VibrationPattern& pattern, ExceptionCode& ec)
-{
-    if (!navigator->frame()->page())
-        return;
-
-    if (navigator->frame()->page()->visibilityState() == PageVisibilityStateHidden)
-        return;
-
-    if (!Vibration::isActive(navigator->frame()->page())) {
-        ec = NOT_SUPPORTED_ERR;
-        return;
-    }
-
-    Vibration::from(navigator->frame()->page())->vibrate(pattern);
+    Vibration::from(page)->vibrate(pattern);
 }
 
 } // namespace WebCore
-
-#endif // ENABLE(VIBRATION)
-