Vibration API: use runtime flag, change from client to platform.

public/platform/Platform.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 364 matching lines @@
     virtual void setSharedTimerFiredFunction(SharedTimerFunction timerFunction) { }
     virtual void setSharedTimerFireInterval(double) { }
     virtual void stopSharedTimer() { }
 
     // Callable from a background WebKit thread.
     virtual void callOnMainThread(void (*func)(void*), void* context) { }
 
     // Checks the partition/volume where fileName resides.
     virtual long long availableDiskSpaceInBytes(const WebString& fileName) { return 0; }
 
+    // Vibration -----------------------------------------------------------

[Peter Beverloo, 2013/06/11 10:19:10]

nit: blank line after this one.

[Michael van Ouwerkerk, 2013/06/11 13:26:51]

Done.

+    virtual void cancelVibration() { }
+    virtual void vibrate(unsigned time) { }

[Peter Beverloo, 2013/06/11 10:19:10]

I'd list "vibrate" before "cancelVibration", because cancelling is something you
can only do with an existing vibration (chronologically speaking).

Could you add basic one-line comments as to what these APIs do, despite the
clear naming?  The unit "time" has to be specified in would be useful
information, what happens with existing vibrations would be interesting,
etcetera.

[Michael van Ouwerkerk, 2013/06/11 13:26:51]

Done.

 
     // Testing -------------------------------------------------------------
 
 #define HAVE_WEBUNITTESTSUPPORT 1
     // Get a pointer to testing support interfaces. Will not be available in production builds.
     virtual WebUnitTestSupport* unitTestSupport() { return 0; }
 
 
     // Tracing -------------------------------------------------------------
 
@@ skipping 128 matching lines @@
     // If null, the platform stops providing device motion data to the current listener.
     virtual void setDeviceMotionListener(WebKit::WebDeviceMotionListener*) { }
 
 protected:
     virtual ~Platform() { }
 };
 
 } // namespace WebKit
 
 #endif