Vibration API: use runtime flag, change from client to platform.

Source/modules/vibration/Vibration.h

 /*
  *  Copyright (C) 2012 Samsung Electronics
  *
  *  This library is free software; you can redistribute it and/or
  *  modify it under the terms of the GNU Library General Public
  *  License as published by the Free Software Foundation; either
  *  version 2 of the License, or (at your option) any later version.
  *
  *  This library is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  *  Library General Public License for more details.
  *
  *  You should have received a copy of the GNU Library General Public License
  *  along with this library; see the file COPYING.LIB.  If not, write to
  *  the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  *  Boston, MA 02110-1301, USA.
  */
 
 #ifndef Vibration_h
 #define Vibration_h
 
-#if ENABLE(VIBRATION)
-
 #include "core/page/Page.h"
 #include "core/platform/Timer.h"
 #include "wtf/PassOwnPtr.h"
 
 namespace WebCore {
 
-class VibrationClient;
-
 class Vibration : public Supplement<Page> {
 public:
     typedef Vector<unsigned> VibrationPattern;
 
-    explicit Vibration(VibrationClient*);
     ~Vibration();
 
-    static PassOwnPtr<Vibration> create(VibrationClient*);
+    static PassOwnPtr<Vibration> create();
 
     void vibrate(const unsigned& time);
     void vibrate(const VibrationPattern&);
     void cancelVibration();
 
     // FIXME : Add suspendVibration() and resumeVibration() to the page visibility feature, when the document.hidden attribute is changed.
     void suspendVibration();
     void resumeVibration();
     void timerStartFired(Timer<Vibration>*);
     void timerStopFired(Timer<Vibration>*);
 
     static const char* supplementName();
     static Vibration* from(Page* page) { return static_cast<Vibration*>(Supplement<Page>::from(page, supplementName())); }
     static bool isActive(Page*);
 
 private:
-    VibrationClient* m_vibrationClient;
+    Vibration();
     Timer<Vibration> m_timerStart;
     Timer<Vibration> m_timerStop;
     bool m_isVibrating;
     VibrationPattern m_pattern;
 };
 
+void provideVibrationTo(Page*);

[Peter Beverloo, 2013/06/11 10:19:10]

Since we already have three methods related to supplementing on Page on the
Vibration class itself, do you think it may be a good idea to include the
lazy-loading logic in ::from()?  The InternalSettings class already does this. 
Then you can remove the provideVibrationTo() method together with the checks in
Vibration.cpp.

[Michael van Ouwerkerk, 2013/06/11 13:26:51]

Much nicer. Done.

+
 } // namespace WebCore
 
-#endif // ENABLE(VIBRATION)
-
 #endif // Vibration_h
-