runtime/bin/main.cc - Issue 15724022: Require exact match of vm arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/main.cc

Issue 15724022: Require exact match of vm arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/main.cc

diff --git a/runtime/bin/main.cc b/runtime/bin/main.cc

index d2bcdba02266c10402d97703a03362785fe4daf4..54f26b2984a2e3403d1c57595073c3cc22daac77 100644

--- a/runtime/bin/main.cc

+++ b/runtime/bin/main.cc

@@ -262,7 +262,7 @@ static bool ProcessMainOptions(const char* option) {

int option_length = strlen(option);

while (name != NULL) {

int length = strlen(name);

- if ((option_length >= length) && (strncmp(option, name, length) == 0)) {

+ if (option_length == length && strncmp(option, name, length) == 0) {

Ivan Posva 2013/06/11 09:55:49 Please keep the parens. How will this match "--sn

Anders Johnsen 2013/06/11 10:44:32 Done. I see, updated.

if (!main_options[i].process(option + length)) {

Log::PrintErr("Invalid option specification : '%s'\n", option);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »