sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart - Issue 15724021: Move array and string related HType from const to a field in the backend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

Issue 15724021: Move array and string related HType from const to a field in the backend. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/codegen.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart (revision 23841)

+++ sdk/lib/_internal/compiler/implementation/ssa/codegen_helpers.dart (working copy)

@@ -15,6 +15,7 @@

* t2 = add(4, 3);

class SsaInstructionMerger extends HBaseVisitor {

+ final Compiler compiler;

/**

* List of [HInstruction] that the instruction merger expects in

* order when visiting the inputs of an instruction.

@@ -33,7 +34,7 @@

generateAtUseSite.add(instruction);

}

- SsaInstructionMerger(this.generateAtUseSite);

+ SsaInstructionMerger(this.generateAtUseSite, this.compiler);

void visitGraph(HGraph graph) {

visitDominatorTree(graph);

@@ -104,7 +105,7 @@

void visitIdentity(HIdentity instruction) {

HInstruction left = instruction.left;

HInstruction right = instruction.right;

- if (singleIdentityComparison(left, right) != null) {

+ if (singleIdentityComparison(left, right, compiler) != null) {

super.visitIdentity(instruction);

}

// Do nothing.