chrome/browser/resources/md_history/history.html - Issue 1572383006: MD History: Hook all elements into the page and add tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/md_history/history.html

Issue 1572383006: MD History: Hook all elements into the page and add tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch

Patch Set: Address reviewer comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html i18n-values="dir:textdirection;lang:language">	2 <html i18n-values="dir:textdirection;lang:language">

3 <head>	3 <head>

4 <meta charset="utf8">	4 <meta charset="utf8">

5 <title i18n-content="title"></title>	5 <title i18n-content="title"></title>

6	6

7 <link rel="stylesheet" href="chrome://resources/css/roboto.css">	7 <link rel="stylesheet" href="chrome://resources/css/roboto.css">

8 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">	8 <link rel="stylesheet" href="chrome://resources/css/text_defaults.css">

	9

	10 <style>

	11 html,

	12 body {

	13 height: 100%;

	14 margin: 0;

	15 }

	16

	17 body {

	18 background: #f2f2f2;
	tsergeant 2016/01/26 23:04:06 Nit: Sort these (hmmm, these sorts of things sho Nit: Sort these (hmmm, these sorts of things should be automatically picked up by the presubmit test. I wonder why it didn't work here) hsampson 2016/01/28 05:44:49 Done. Show quoted text On 2016/01/26 23:04:06, tsergeant wrote: > Nit: Sort these > > > (hmmm, these sorts of things should be automatically picked up by the presubmit > test. I wonder why it didn't work here) Done.
	19 font-family: Roboto;

	20 font-size: 13px;

	21 display: flex;

	22 flex-direction:column;
	Dan Beam 2016/01/26 23:06:43 also, space after flex-direction: also, space after flex-direction: hsampson 2016/01/28 05:44:49 Done. Show quoted text On 2016/01/26 23:06:43, Dan Beam wrote: > also, space after flex-direction: Done.
	23 }

	24

	25 #toolbar {

	26 flex: 0 0 56px;

	27 }

	28

	29 #history-card-manager {

	30 flex: 1 0 0;

	31 overflow: auto;

	32 }

	33 </style>

9 </head>	34 </head>

10	35

11 <body>	36 <body>

12 <h1 i18n-content="title"></h1>	37 <history-toolbar class="paper-header" id="toolbar"></history-toolbar>

	38 <history-card-manager id="history-card-manager"></history-card-manager>

	39

13 <link rel="import" href="chrome://resources/html/polymer_config.html">	40 <link rel="import" href="chrome://resources/html/polymer_config.html">

	41 <link rel="import" href="chrome://resources/html/cr.html">

	42 <link rel="import" href="chrome://resources/html/util.html">

	43 <link rel="import" href="chrome://history/history_card_manager.html">

	44 <link rel="import" href="chrome://history/history_toolbar.html">

	45

	46 <script src="history.js"></script>

14	47

15 <!-- Prepare strings and perform i18n substitutions. -->	48 <!-- Prepare strings and perform i18n substitutions. -->

16 <link rel="import" href="chrome://resources/html/load_time_data.html">	49 <link rel="import" href="chrome://resources/html/load_time_data.html">

17 <script src="strings.js"></script>	50 <script src="strings.js"></script>

18 <link rel="import" href="chrome://resources/html/i18n_template.html">	51 <link rel="import" href="chrome://resources/html/i18n_template.html">

19 </body>	52 </body>

20	53

21 </html>	54 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/resources/md_history/compiled_resources.gyp ('k') | chrome/browser/resources/md_history/history.js » ('j') | no next file with comments »