QuicAlarms are now allocated out of an arena in QuicConnection

relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965

Fix a static_assert in quic_arena_scoped_ptr. No runtime or functional change.

Merge internal change: 111881552

relnote: n/a. Apply language fixes to QuicArenaScopedPtr/QuicOneBlockArena to allow them to build in Chromium. Not flag protected.

Merge internal change:  112057527

Committed: https://crrev.com/4ea54a24b7adab2c793fdcfdc01ff57363ceb9d2
Cr-Commit-Position: refs/heads/master@{#370803}

[Jeremy Dorfman, 2016-01-21 18:44:10]

Description was changed from

==========
Fix MSVC and iOS issues with QuicOneBlockArena.

BUG=
==========

to

==========
relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded
by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965

BUG=
==========

[Jeremy Dorfman, 2016-01-21 18:44:34]

jdorfman@google.com changed reviewers:
+ rch@chromium.org

[Jeremy Dorfman, 2016-01-21 18:45:34]

Description was changed from

==========
relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded
by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965

BUG=
==========

to

==========
relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded
by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965,112057527

BUG=
==========

[Ryan Hamilton, 2016-01-21 18:45:39]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-01-21 18:45:39]

lgtm

[Ryan Hamilton, 2016-01-21 18:45:47]

The CQ bit was unchecked by rch@chromium.org

[Jeremy Dorfman, 2016-01-21 18:45:55]

The CQ bit was checked by jdorfman@google.com

[commit-bot: I haz the power, 2016-01-21 18:46:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572353002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572353002/140001

[Ryan Hamilton, 2016-01-21 18:48:50]

Description was changed from

==========
relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded
by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965,112057527

BUG=
==========

to

==========
relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded
by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965

Fix a static_assert in quic_arena_scoped_ptr. No runtime or functional change.

Merge internal change: 111881552 

relnote: n/a. Apply language fixes to QuicArenaScopedPtr/QuicOneBlockArena to
allow them to build in Chromium. Not flag protected.

Merge internal change:  112057527
==========

[commit-bot: I haz the power, 2016-01-21 18:50:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 18:50:16]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Ryan Hamilton, 2016-01-21 18:50:28]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-01-21 18:51:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572353002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572353002/140001

[commit-bot: I haz the power, 2016-01-21 18:53:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 18:53:45]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Ryan Hamilton, 2016-01-21 21:23:05]

The CQ bit was checked by rch@chromium.org

[Ryan Hamilton, 2016-01-21 21:23:05]

lgtm

lgtm. wornder what's up with the purple bots. let's see if they fix theselves...

[commit-bot: I haz the power, 2016-01-21 21:24:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572353002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572353002/160001

[commit-bot: I haz the power, 2016-01-21 22:12:57]

Description was changed from

==========
relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded
by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965

Fix a static_assert in quic_arena_scoped_ptr. No runtime or functional change.

Merge internal change: 111881552 

relnote: n/a. Apply language fixes to QuicArenaScopedPtr/QuicOneBlockArena to
allow them to build in Chromium. Not flag protected.

Merge internal change:  112057527
==========

to

==========
relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded
by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965

Fix a static_assert in quic_arena_scoped_ptr. No runtime or functional change.

Merge internal change: 111881552 

relnote: n/a. Apply language fixes to QuicArenaScopedPtr/QuicOneBlockArena to
allow them to build in Chromium. Not flag protected.

Merge internal change:  112057527
==========

[commit-bot: I haz the power, 2016-01-21 22:12:58]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-01-21 22:13:52]

Description was changed from

==========
relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded
by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965

Fix a static_assert in quic_arena_scoped_ptr. No runtime or functional change.

Merge internal change: 111881552 

relnote: n/a. Apply language fixes to QuicArenaScopedPtr/QuicOneBlockArena to
allow them to build in Chromium. Not flag protected.

Merge internal change:  112057527
==========

to

==========
relnote: QuicAlarms are now allocated out of an arena in QuicConnection. Guarded
by quic_enable_arena_allocation. Enabled by default.

This results in around a 2% improvement in CPU usage, which mostly comes
from reducing the number of stalls whenever an alarm fires.

Enabled by default because otherwise, QuicConnections use extra memory
that they never use.

Merge internal change: 111441965

Fix a static_assert in quic_arena_scoped_ptr. No runtime or functional change.

Merge internal change: 111881552

relnote: n/a. Apply language fixes to QuicArenaScopedPtr/QuicOneBlockArena to
allow them to build in Chromium. Not flag protected.

Merge internal change:  112057527

Committed: https://crrev.com/4ea54a24b7adab2c793fdcfdc01ff57363ceb9d2
Cr-Commit-Position: refs/heads/master@{#370803}
==========

[commit-bot: I haz the power, 2016-01-21 22:13:53]

Patchset 9 (id:??) landed as
https://crrev.com/4ea54a24b7adab2c793fdcfdc01ff57363ceb9d2
Cr-Commit-Position: refs/heads/master@{#370803}