Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1572333002: [Interpreter] Add StackCheck node to BytecodeGraphBuilder graphs. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add StackCheck node to BytecodeGraphBuilder graphs. This fixes a number of crashes where other code was assuming there would be at least one deopt point in all optimized functions (i.e., the StackCheck) but we weren't producing any. BUG=v8:4280 LOG=N Committed: https://crrev.com/9b52c52845767c9b9275f3ab9d39a41ebeac289a Cr-Commit-Position: refs/heads/master@{#33243}

Patch Set 1 #

Patch Set 2 : Add some skips back #

Patch Set 3 : Fix skip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -64 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +16 lines, -0 lines 0 comments Download
M test/cctest/cctest.status View 3 chunks +0 lines, -12 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 15 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
rmcilroy
Jaro, please take a look, thanks.
4 years, 11 months ago (2016-01-11 15:51:14 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1572333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1572333002/1
4 years, 11 months ago (2016-01-11 15:51:14 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12228)
4 years, 11 months ago (2016-01-11 16:26:45 UTC) #6
rmcilroy
Jaro, please take a look, thanks.
4 years, 11 months ago (2016-01-12 10:42:01 UTC) #8
Jarin
lgtm. Thanks!
4 years, 11 months ago (2016-01-12 10:57:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1572333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1572333002/20001
4 years, 11 months ago (2016-01-12 11:11:52 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/12266)
4 years, 11 months ago (2016-01-12 11:32:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1572333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1572333002/40001
4 years, 11 months ago (2016-01-12 16:05:46 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-12 17:08:10 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 17:08:38 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9b52c52845767c9b9275f3ab9d39a41ebeac289a
Cr-Commit-Position: refs/heads/master@{#33243}

Powered by Google App Engine
This is Rietveld 408576698