Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1572293002: [turbofan] Make context deoptmizable (Closed)

Created:
4 years, 11 months ago by sigurds
Modified:
4 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make context deoptmizable Escape analysis will eliminate the context, if possible. Materialization must then ensure that the materialized object has the right map, and that the context register is set accordingly. R=jarin@chromium.org BUG=569530, v8:4586 LOG=n Committed: https://crrev.com/b5a34b3d29ca6017246776e02627b53c1036df5c Cr-Commit-Position: refs/heads/master@{#33201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M src/deoptimizer.cc View 4 chunks +11 lines, -2 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sigurds
As discussed offline, PTAL.
4 years, 11 months ago (2016-01-11 11:44:38 UTC) #1
Jarin
lgtm. Thanks!
4 years, 11 months ago (2016-01-11 12:40:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1572293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1572293002/1
4 years, 11 months ago (2016-01-11 12:46:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 12:47:55 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 12:48:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b5a34b3d29ca6017246776e02627b53c1036df5c
Cr-Commit-Position: refs/heads/master@{#33201}

Powered by Google App Engine
This is Rietveld 408576698