[Interpreter] Add wide context slot load / store operations.

[Interpreter] Add wide context slot load / store operations.

Adds wide context slot load / store operations. Adds LdaContextSlotWide
and StaContextSlotWide bytecodes.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/2e2e6b41b55aea182c1db9c808555b1e6864b36c
Cr-Commit-Position: refs/heads/master@{#33211}

[rmcilroy, 2016-01-11 10:38:16]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 10:38:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572283002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572283002/1

[rmcilroy, 2016-01-11 10:38:54]

rmcilroy@chromium.org changed reviewers:
+ bmeurer@chromium.org, oth@chromium.org

[rmcilroy, 2016-01-11 10:38:54]

Benedikt, please take a look at compiler/ changes.

Orion, please take a look at overall CL.

Thanks.

[commit-bot: I haz the power, 2016-01-11 10:40:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 10:40:18]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13902)

[Benedikt Meurer, 2016-01-11 10:44:53]

LGTM on compiler.

[oth, 2016-01-11 11:31:11]

lgtm. Minor comments that may not need action and there's a  typo in the commit
message s/constext/context/.
Thanks!

https://codereview.chromium.org/1572283002/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1572283002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:114: #define UNIQUE_VAR()
"var a" XSTR(__COUNTER__) " = 0;\n"
Does this need to be flagged with the core v8 team before adding to the code
base? It's the only instance of __COUNTER__ in the code base and it's a non-Cxx
standard that's implemented in assorted compilers.

https://codereview.chromium.org/1572283002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:4033: int wide_slot =
first_context_slot + 3;
This code could STATIC_ASSERT that the limit of wide slot <= 255 as this'll be
wrong as fast failure.

[rmcilroy, 2016-01-11 15:37:51]

Description was changed from

==========
[Interpreter] Add wide constext slot load / store operations.

Adds wide constext slot load / store operations. Adds LdaContextSlotWide
and StaContextSlotWide bytecodes.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Add wide context slot load / store operations.

Adds wide context slot load / store operations. Adds LdaContextSlotWide
and StaContextSlotWide bytecodes.

BUG=v8:4280
LOG=N
==========

[rmcilroy, 2016-01-11 15:47:19]

> Minor comments that may not need action and there's a  typo in the commit
> message s/constext/context/.

Done.

https://codereview.chromium.org/1572283002/diff/1/test/cctest/interpreter/tes...
File test/cctest/interpreter/test-bytecode-generator.cc (right):

https://codereview.chromium.org/1572283002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:114: #define UNIQUE_VAR()
"var a" XSTR(__COUNTER__) " = 0;\n"
On 2016/01/11 11:31:11, oth wrote:
> Does this need to be flagged with the core v8 team before adding to the code
> base? It's the only instance of __COUNTER__ in the code base and it's a
non-Cxx
> standard that's implemented in assorted compilers.

I think this is OK (assuming it passes the bots) - it is only in tests, and is
used all over the place in Chromium.

https://codereview.chromium.org/1572283002/diff/1/test/cctest/interpreter/tes...
test/cctest/interpreter/test-bytecode-generator.cc:4033: int wide_slot =
first_context_slot + 3;
On 2016/01/11 11:31:11, oth wrote:
> This code could STATIC_ASSERT that the limit of wide slot <= 255 as this'll be
> wrong as fast failure.

Done.

[rmcilroy, 2016-01-11 15:47:24]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 15:47:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572283002/20001

[commit-bot: I haz the power, 2016-01-11 16:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 16:20:17]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-01-11 16:36:19]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2016-01-11 16:36:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, oth@chromium.org
Link to the patchset: https://codereview.chromium.org/1572283002/#ps20001
(title: "Address review comments.")

[commit-bot: I haz the power, 2016-01-11 16:36:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1572283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1572283002/20001

[commit-bot: I haz the power, 2016-01-11 16:37:56]

Description was changed from

==========
[Interpreter] Add wide context slot load / store operations.

Adds wide context slot load / store operations. Adds LdaContextSlotWide
and StaContextSlotWide bytecodes.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Add wide context slot load / store operations.

Adds wide context slot load / store operations. Adds LdaContextSlotWide
and StaContextSlotWide bytecodes.

BUG=v8:4280
LOG=N
==========

[commit-bot: I haz the power, 2016-01-11 16:37:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-11 16:38:39]

Description was changed from

==========
[Interpreter] Add wide context slot load / store operations.

Adds wide context slot load / store operations. Adds LdaContextSlotWide
and StaContextSlotWide bytecodes.

BUG=v8:4280
LOG=N
==========

to

==========
[Interpreter] Add wide context slot load / store operations.

Adds wide context slot load / store operations. Adds LdaContextSlotWide
and StaContextSlotWide bytecodes.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/2e2e6b41b55aea182c1db9c808555b1e6864b36c
Cr-Commit-Position: refs/heads/master@{#33211}
==========

[commit-bot: I haz the power, 2016-01-11 16:38:39]

Patchset 2 (id:??) landed as
https://crrev.com/2e2e6b41b55aea182c1db9c808555b1e6864b36c
Cr-Commit-Position: refs/heads/master@{#33211}