Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 15722005: Simple rewrite of generate-bindings.pl in Python (Closed)

Created:
7 years, 6 months ago by Nils Barth (inactive)
Modified:
7 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, jsbell+bindings_chromium.org, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, kojih
Visibility:
Public.

Description

Closed; superseded by full rewrite in: Issue 18190004: Add Python flow to bindings generation, move dummy-generating IDL files over https://codereview.chromium.org/18190004/ Simple rewrite of generate-bindings.pl in Python This is a simplied version of full rewrite, which is mostly stubs, with the only substantial logic being reading and processing the JSON. Imported JSON is then dumped to stdout for inspection. Includes a test JSON file so not blocked on Perl JSON export patches. Test via: ./generate_bindings.py --output-directory=test test/BarProp.json Test data generated by: md test && ./generate-bindings.pl --outputDir=test --dump-json ../../../Source/core/page/BarProp.idl ...after applying: Issue 16296004: JSON export from generate-bindings.pl https://codereview.chromium.org/16296004/ Simplification of: Issue 15959019: Rewrite generate-bindings.pl in Python https://codereview.chromium.org/15959019/ BUG=239771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -0 lines) Patch
A Source/bindings/scripts/code_generator_v8.py View 1 chunk +35 lines, -0 lines 0 comments Download
A Source/bindings/scripts/generate_bindings.py View 1 chunk +64 lines, -0 lines 0 comments Download
A Source/bindings/scripts/json_import_export.py View 1 chunk +80 lines, -0 lines 0 comments Download
A Source/bindings/scripts/test/BarProp.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nils Barth (inactive)
7 years, 6 months ago (2013-06-04 04:12:14 UTC) #1
Hi haraken,
Here's the simplified rewrite, mostly just stubs;
only real logic is reading in and processing JSON.

Powered by Google App Engine
This is Rietveld 408576698