Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 15721007: Make expressions like "if (weak_ptr)" work (Closed)

Created:
7 years, 6 months ago by akalin
Modified:
7 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Make expressions like "if (weak_ptr)" work Use the same trick as scoped_ptr<T>. Add comments regarding == and != operators and their relation to the bool trick. BUG=245942 R=darin@chromium.org, rsleevi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204438

Patch Set 1 #

Patch Set 2 : Update comments #

Patch Set 3 : Fix comment again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M base/memory/scoped_ptr.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M base/memory/weak_ptr.h View 1 2 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
akalin
+rsleevi for review +darin for owners (will probably TBR)
7 years, 6 months ago (2013-06-04 19:58:34 UTC) #1
darin (slow to review)
LGTM
7 years, 6 months ago (2013-06-04 20:10:20 UTC) #2
akalin
+enne FYI
7 years, 6 months ago (2013-06-04 21:02:34 UTC) #3
enne (OOO)
On 2013/06/04 21:02:34, akalin wrote: > +enne FYI Thanks for the extra comments. :)
7 years, 6 months ago (2013-06-04 21:05:10 UTC) #4
Ryan Sleevi
lgtm
7 years, 6 months ago (2013-06-04 21:10:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/15721007/17001
7 years, 6 months ago (2013-06-05 18:22:42 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=158221
7 years, 6 months ago (2013-06-06 01:29:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/15721007/17001
7 years, 6 months ago (2013-06-06 03:06:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/15721007/51001
7 years, 6 months ago (2013-06-06 03:59:59 UTC) #9
akalin
7 years, 6 months ago (2013-06-06 05:32:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 manually as r204438 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698