Don't log stack trace for a bad package URL in a source file.

Don't log stack trace for a bad package URL in a source file.

BUG=https://github.com/dart-lang/sdk/issues/25367
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/5cc87405aa5f10f6ca97fdaa0e524a63747439b2

[skybrian, 2016-01-09 08:19:54]

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/test/ge...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/test/ge...
pkg/analyzer/test/generated/all_the_rest_test.dart:578: void
test_visitVariableDeclaration_static_const_inClassWithConstConstructor() {
Not sure what dartfmt is doing here; it seems to have reversed a previous patch:
https://codereview.chromium.org/1524893002/patch/1/10027

[skybrian, 2016-01-09 08:20:40]

skybrian@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-01-09 16:02:39]

LGTM

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/lib/src...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/lib/src...
pkg/analyzer/lib/src/generated/source.dart:845: if (packageUri != null) {
This 'if' ought to be inside the 'try' because packageUri will only be non-null
if an exception is not thrown.

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/test/ge...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/test/ge...
pkg/analyzer/test/generated/all_the_rest_test.dart:578: void
test_visitVariableDeclaration_static_const_inClassWithConstConstructor() {
I'm not sure either, but we always format, regardless of what the formatter
does, so you don't need to worry about it.

[skybrian, 2016-01-09 19:26:45]

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/lib/src...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/lib/src...
pkg/analyzer/lib/src/generated/source.dart:845: if (packageUri != null) {
On 2016/01/09 16:02:39, Brian Wilkerson wrote:
> This 'if' ought to be inside the 'try' because packageUri will only be
non-null
> if an exception is not thrown.

That's true but it seems like it would be less clear because my intention is to
only ignore exceptions thrown by _packages.resolve, not within .replace (for
example).

[Brian Wilkerson, 2016-01-10 16:55:25]

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/lib/src...
File pkg/analyzer/lib/src/generated/source.dart (right):

https://chromiumcodereview.appspot.com/1572073003/diff/1/pkg/analyzer/lib/src...
pkg/analyzer/lib/src/generated/source.dart:845: if (packageUri != null) {
I disagree (hence the comment), but it's your call (I already gave an
unqualified LGTM because I agree that it's semantically valid).

[skybrian, 2016-01-11 23:53:52]

Description was changed from

==========
Don't log stack trace for a bad package URL in a source file.

BUG=https://github.com/dart-lang/sdk/issues/25367
==========

to

==========
Don't log stack trace for a bad package URL in a source file.

BUG=https://github.com/dart-lang/sdk/issues/25367
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5cc87405aa5f10f6ca97fdaa0e524a63747439b2
==========

[skybrian, 2016-01-11 23:53:53]

Committed patchset #1 (id:1) manually as
5cc87405aa5f10f6ca97fdaa0e524a63747439b2 (presubmit successful).