Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: ui/views/mus/platform_window_mus.cc

Issue 1571953003: Changes PlatformWindowMus to ack event callback before dispatching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/mus/platform_window_mus.cc
diff --git a/ui/views/mus/platform_window_mus.cc b/ui/views/mus/platform_window_mus.cc
index 3683cf5ba15d425a5a1ede9b67d15f0840d7fb47..7dd704529d956a62007dd133b063e809d228acfb 100644
--- a/ui/views/mus/platform_window_mus.cc
+++ b/ui/views/mus/platform_window_mus.cc
@@ -212,6 +212,11 @@ void PlatformWindowMus::OnWindowInputEvent(
mus::Window* view,
mus::mojom::EventPtr event,
scoped_ptr<base::Closure>* ack_callback) {
+ // It's possible dispatching the event will spin a nested message loop. Ack
+ // the callback now, otherwise we appear unresponsive for the life of the
+ // nested message loop.
+ (*ack_callback)->Run();
+ ack_callback->reset();
scoped_ptr<ui::Event> ui_event(event.To<scoped_ptr<ui::Event>>());
delegate_->DispatchEvent(ui_event.get());
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698