Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: remoting/client/plugin/pepper_port_allocator.h

Issue 1571943002: Simplify PortAllocatorBase and make PortAllocator creation synchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/client/plugin/pepper_port_allocator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/client/plugin/pepper_port_allocator.h
diff --git a/remoting/client/plugin/pepper_port_allocator.h b/remoting/client/plugin/pepper_port_allocator.h
index 19fb03d5cef362fb00224f1c8c2329994f19d61b..a254977fd0685744c366130b3443b63daeef132c 100644
--- a/remoting/client/plugin/pepper_port_allocator.h
+++ b/remoting/client/plugin/pepper_port_allocator.h
@@ -18,10 +18,13 @@ namespace remoting {
// client plugin. It uses Pepper URLLoader API when creating relay sessions.
class PepperPortAllocator : public protocol::PortAllocatorBase {
public:
- static scoped_ptr<PepperPortAllocator> Create(
- const pp::InstanceHandle& instance);
+ PepperPortAllocator(
+ scoped_refptr<protocol::TransportContext> transport_context,
+ pp::InstanceHandle pp_instance);
~PepperPortAllocator() override;
+ pp::InstanceHandle pp_instance() { return pp_instance_; }
+
// PortAllocatorBase overrides.
cricket::PortAllocatorSession* CreateSessionInternal(
const std::string& content_name,
@@ -30,12 +33,7 @@ class PepperPortAllocator : public protocol::PortAllocatorBase {
const std::string& ice_password) override;
private:
- PepperPortAllocator(
- const pp::InstanceHandle& instance,
- scoped_ptr<rtc::NetworkManager> network_manager,
- scoped_ptr<rtc::PacketSocketFactory> socket_factory);
-
- pp::InstanceHandle instance_;
+ pp::InstanceHandle pp_instance_;
scoped_ptr<rtc::NetworkManager> network_manager_;
scoped_ptr<rtc::PacketSocketFactory> socket_factory_;
@@ -44,14 +42,15 @@ class PepperPortAllocator : public protocol::PortAllocatorBase {
class PepperPortAllocatorFactory : public protocol::PortAllocatorFactory {
public:
- PepperPortAllocatorFactory(const pp::InstanceHandle& instance);
+ PepperPortAllocatorFactory(pp::InstanceHandle pp_instance);
~PepperPortAllocatorFactory() override;
// PortAllocatorFactory interface.
- scoped_ptr<protocol::PortAllocatorBase> CreatePortAllocator() override;
+ scoped_ptr<cricket::PortAllocator> CreatePortAllocator(
+ scoped_refptr<protocol::TransportContext> transport_context) override;
private:
- pp::InstanceHandle instance_;
+ pp::InstanceHandle pp_instance_;
DISALLOW_COPY_AND_ASSIGN(PepperPortAllocatorFactory);
};
« no previous file with comments | « no previous file | remoting/client/plugin/pepper_port_allocator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698