Simplify PortAllocatorBase and make PortAllocator creation synchronous.

remoting/protocol/port_allocator_base.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/port_allocator_base.h"
 
 #include <algorithm>
 #include <map>
 
+#include "base/bind.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "net/base/escape.h"
+#include "remoting/protocol/network_settings.h"
+#include "remoting/protocol/transport_context.h"
 
 namespace {
 
 typedef std::map<std::string, std::string> StringMap;
 
 // Parses the lines in the result of the HTTP request that are of the form
 // 'a=b' and returns them in a map.
 StringMap ParseMap(const std::string& string) {
   StringMap map;
   base::StringPairs pairs;
   base::SplitStringIntoKeyValuePairs(string, '\r', '=', &pairs);
 
   for (auto& pair : pairs) {
     map[pair.first] = pair.second;
   }
   return map;
 }
 
 }  // namespace
 
 namespace remoting {
 namespace protocol {
 
 const int PortAllocatorBase::kNumRetries = 5;
 
-PortAllocatorBase::PortAllocatorBase(rtc::NetworkManager* network_manager,
-                                     rtc::PacketSocketFactory* socket_factory)
-    : BasicPortAllocator(network_manager, socket_factory) {}
+PortAllocatorBase::PortAllocatorBase(
+    scoped_ptr<rtc::NetworkManager> network_manager,
+    scoped_ptr<rtc::PacketSocketFactory> socket_factory,
+    scoped_refptr<TransportContext> transport_context)
+    : BasicPortAllocator(network_manager.get(), socket_factory.get()),
+      network_manager_(std::move(network_manager)),
+      socket_factory_(std::move(socket_factory)),
+      transport_context_(transport_context) {
+  // We always use PseudoTcp to provide a reliable channel. It provides poor
+  // performance when combined with TCP-based transport, so we have to disable
+  // TCP ports. ENABLE_SHARED_UFRAG flag is specified so that the same username
+  // fragment is shared between all candidates.
+  int flags = cricket::PORTALLOCATOR_DISABLE_TCP |
+              cricket::PORTALLOCATOR_ENABLE_SHARED_UFRAG |
+              cricket::PORTALLOCATOR_ENABLE_IPV6;
+
+  NetworkSettings network_settings = transport_context_->network_settings();
+
+  if (!(network_settings.flags & NetworkSettings::NAT_TRAVERSAL_STUN))
+    flags |= cricket::PORTALLOCATOR_DISABLE_STUN;
+
+  if (!(network_settings.flags & NetworkSettings::NAT_TRAVERSAL_RELAY))
+    flags |= cricket::PORTALLOCATOR_DISABLE_RELAY;
+
+  set_flags(flags);
+  SetPortRange(network_settings.port_range.min_port,
+                       network_settings.port_range.max_port);
+}
 
 PortAllocatorBase::~PortAllocatorBase() {}
 
-void PortAllocatorBase::SetStunHosts(
-    const std::vector<rtc::SocketAddress>& hosts) {
-  stun_hosts_ = hosts;
-}
-
-void PortAllocatorBase::SetRelayHosts(const std::vector<std::string>& hosts) {
-  relay_hosts_ = hosts;
-}
-
-void PortAllocatorBase::SetRelayToken(const std::string& relay) {
-  relay_token_ = relay;
-}
-
 PortAllocatorSessionBase::PortAllocatorSessionBase(
     PortAllocatorBase* allocator,
     const std::string& content_name,
     int component,
     const std::string& ice_ufrag,
-    const std::string& ice_pwd,
-    const std::vector<rtc::SocketAddress>& stun_hosts,
-    const std::vector<std::string>& relay_hosts,
-    const std::string& relay_token)
+    const std::string& ice_pwd)
     : BasicPortAllocatorSession(allocator,
                                 content_name,
                                 component,
                                 ice_ufrag,
                                 ice_pwd),
-      relay_hosts_(relay_hosts),
-      stun_hosts_(stun_hosts),
-      relay_token_(relay_token),
-      attempts_(0) {}
+      transport_context_(allocator->transport_context()),
+      weak_factory_(this) {}
 
 PortAllocatorSessionBase::~PortAllocatorSessionBase() {}
 
 void PortAllocatorSessionBase::GetPortConfigurations() {
+  transport_context_->GetJingleInfo(base::Bind(
+      &PortAllocatorSessionBase::OnJingleInfo, weak_factory_.GetWeakPtr()));
+}
+
+void PortAllocatorSessionBase::OnJingleInfo(
+    std::vector<rtc::SocketAddress> stun_hosts,
+    std::vector<std::string> relay_hosts,
+    std::string relay_token) {
+  stun_hosts_ = stun_hosts;
+  relay_hosts_ = relay_hosts;
+  relay_token_ = relay_token;
+
   // Creating relay sessions can take time and is done asynchronously.
   // Creating stun sessions could also take time and could be done aysnc also,
   // but for now is done here and added to the initial config.  Note any later
   // configs will have unresolved stun ips and will be discarded by the
   // AllocationSequence.
   cricket::ServerAddresses hosts;
   for (const auto& host : stun_hosts_) {
     hosts.insert(host);
   }
 
   cricket::PortConfiguration* config =
       new cricket::PortConfiguration(hosts, username(), password());
   ConfigReady(config);
   TryCreateRelaySession();
 }
 
 void PortAllocatorSessionBase::TryCreateRelaySession() {
-  if (allocator()->flags() & cricket::PORTALLOCATOR_DISABLE_RELAY)
+  if (flags() & cricket::PORTALLOCATOR_DISABLE_RELAY)
     return;
 
   if (attempts_ == PortAllocatorBase::kNumRetries) {
     LOG(ERROR) << "PortAllocator: maximum number of requests reached; "
                   << "giving up on relay.";
     return;
   }
 
   if (relay_hosts_.empty()) {
     LOG(ERROR) << "PortAllocator: no relay hosts configured.";
     return;
   }
 
   if (relay_token_.empty()){
     LOG(WARNING) << "No relay auth token found.";
     return;
   }
 
   // Choose the next host to try.
   std::string host = relay_hosts_[attempts_ % relay_hosts_.size()];
   attempts_++;
   SendSessionRequest(host);
 }
 
-PortAllocatorBase* PortAllocatorSessionBase::allocator() {
-  return static_cast<PortAllocatorBase*>(
-      BasicPortAllocatorSession::allocator());
-}
-
 std::string PortAllocatorSessionBase::GetSessionRequestUrl() {
   ASSERT(!username().empty());
   ASSERT(!password().empty());
   return "/create_session?username=" +
          net::EscapeUrlEncodedData(username(), false) + "&password=" +
          net::EscapeUrlEncodedData(password(), false);
 }
 
 void PortAllocatorSessionBase::ReceiveSessionResponse(
     const std::string& response) {
@@ skipping 25 matching lines @@
     relay_config.ports.push_back(
         cricket::ProtocolAddress(address, cricket::PROTO_UDP));
     config->AddRelay(relay_config);
   }
 
   ConfigReady(config);
 }
 
 }  // namespace protocol
 }  // namespace remoting