Might as well inline these premultiplies.

Might as well inline these premultiplies.

We're paying quite a bit of function-call overhead per pixel.

On one test image we spend 3.5% of our total time in swizzle_rgba_to_n32_premul() and 8.8% of our total time in SkPreMultiplyARGB().  That turns into just 8.8% of our total time in swizzle_rgba_to_n32_premul() after inlining.

That's about a 30% speedup.

This will make SIMD procs look worse, so it's nice to land this first.

BUG=skia:4767
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1571923002

Committed: https://skia.googlesource.com/skia/+/3d00db39c6637607a2a1f184be2f31e4fe17d9ad

[mtklein_C, 2016-01-08 22:42:27]

Description was changed from

==========
Might as well inline these premultiplies.

We're paying quite a bit of function-call overhead per pixel.

This will make SIMD procs look worse, so it's nice to land this first.

BUG=skia:4767
==========

to

==========
Might as well inline these premultiplies.

We're paying quite a bit of function-call overhead per pixel.

This will make SIMD procs look worse, so it's nice to land this first.

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein, 2016-01-08 22:52:06]

Description was changed from

==========
Might as well inline these premultiplies.

We're paying quite a bit of function-call overhead per pixel.

This will make SIMD procs look worse, so it's nice to land this first.

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Might as well inline these premultiplies.

We're paying quite a bit of function-call overhead per pixel.

On one test image we spend 3.5% of our total time in
swizzle_rgba_to_n32_premul() and 8.8% of our total time in SkPreMultiplyARGB(). 
That turns into just 8.8% of our total time in swizzle_rgba_to_n32_premul()
after inlining.

That's about a 30% speedup.

This will make SIMD procs look worse, so it's nice to land this first.

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2016-01-08 22:52:42]

mtklein@chromium.org changed reviewers:
+ msarett@google.com

[mtklein_C, 2016-01-08 22:52:46]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 22:52:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571923002/1

[commit-bot: I haz the power, 2016-01-08 23:12:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 23:12:23]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-01-11 13:53:06]

lgtm

[mtklein, 2016-01-11 13:58:03]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-01-11 13:58:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571923002/1

[commit-bot: I haz the power, 2016-01-11 14:16:29]

Description was changed from

==========
Might as well inline these premultiplies.

We're paying quite a bit of function-call overhead per pixel.

On one test image we spend 3.5% of our total time in
swizzle_rgba_to_n32_premul() and 8.8% of our total time in SkPreMultiplyARGB(). 
That turns into just 8.8% of our total time in swizzle_rgba_to_n32_premul()
after inlining.

That's about a 30% speedup.

This will make SIMD procs look worse, so it's nice to land this first.

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Might as well inline these premultiplies.

We're paying quite a bit of function-call overhead per pixel.

On one test image we spend 3.5% of our total time in
swizzle_rgba_to_n32_premul() and 8.8% of our total time in SkPreMultiplyARGB(). 
That turns into just 8.8% of our total time in swizzle_rgba_to_n32_premul()
after inlining.

That's about a 30% speedup.

This will make SIMD procs look worse, so it's nice to land this first.

BUG=skia:4767
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/3d00db39c6637607a2a1f184be2f31e4fe17d9ad
==========

[commit-bot: I haz the power, 2016-01-11 14:16:30]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3d00db39c6637607a2a1f184be2f31e4fe17d9ad