Issue 15719006: Fix for caller of GetTmpDir.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15719006: Fix for caller of GetTmpDir. (Closed)

Created:
7 years, 6 months ago by scroggo

Modified:
7 years, 6 months ago

Reviewers:
epoger

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix for caller of GetTmpDir. Since I changed GetTmpDir to create an SkString each time, it needs to be assigned to a variable in order for it to stick around. Update a test which I missed because my client was out of date. Committed: https://code.google.com/p/skia/source/detail?r=9475

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -4 lines)			Patch
	M	tests/DataRefTest.cpp	View		1 chunk	+3 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

epoger

LGTM Leon, it looks like maybe I steered you the wrong direction in https://codereview.chromium.org/16098011/#msg2 . ...

7 years, 6 months ago (2013-06-07 14:26:54 UTC) #2

Message was sent while issue was closed.

Committed manually as r9475 (presubmit successful).

Expand Messages | Collapse Messages