Update the Payments integration setting now that it now governs uploads.

Update the Payments integration setting now that it now governs uploads.

The setting string now refers to syncing cards rather than just showing them. And the setting is always shown when autofill syncing is enabled, regardless of whether the user already has cards in Payments.

BUG=535784
Committed: https://crrev.com/4b319fe9db26b7fb7fc9bb0ed00ae9717795438c
Cr-Commit-Position: refs/heads/master@{#369253}

[Justin Donnelly, 2016-01-12 22:26:08]

jdonnelly@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-01-13 03:55:39]

lgtm

https://codereview.chromium.org/1571863002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1571863002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:9668: +          Sync credit card and address
information with Google Payments
we'd still allow downstreaming of cards for users with sync passphrases, right?
For them, this string doesn't make as much sense.

[Justin Donnelly, 2016-01-13 15:38:56]

https://codereview.chromium.org/1571863002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1571863002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:9668: +          Sync credit card and address
information with Google Payments
On 2016/01/13 03:55:39, Evan Stade wrote:
> we'd still allow downstreaming of cards for users with sync passphrases,
right?
> For them, this string doesn't make as much sense.

Good point. I'll ask Hwi and Zach about this.

[Justin Donnelly, 2016-01-13 18:56:16]

https://codereview.chromium.org/1571863002/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1571863002/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:9668: +          Sync credit card and address
information with Google Payments
On 2016/01/13 15:38:56, Justin Donnelly wrote:
> On 2016/01/13 03:55:39, Evan Stade wrote:
> > we'd still allow downstreaming of cards for users with sync passphrases,
> right?
> > For them, this string doesn't make as much sense.
> 
> Good point. I'll ask Hwi and Zach about this.

Final decision was to use this string in all cases and to explain the effect of
using a passphrase in the help center.

Also, FYI, I updated the string to reflect the final wordsmithing.

[Justin Donnelly, 2016-01-13 18:56:19]

The CQ bit was checked by jdonnelly@chromium.org

[Justin Donnelly, 2016-01-13 18:56:19]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1571863002/#ps40001
(title: "UI string wordsmithing")

[commit-bot: I haz the power, 2016-01-13 18:57:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1571863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1571863002/40001

[commit-bot: I haz the power, 2016-01-13 20:10:32]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-13 20:11:35]

Description was changed from

==========
Update the Payments integration setting now that it now governs uploads.

The setting string now refers to syncing cards rather than just showing them.
And the setting is always shown when autofill syncing is enabled, regardless of
whether the user already has cards in Payments.

BUG=535784
==========

to

==========
Update the Payments integration setting now that it now governs uploads.

The setting string now refers to syncing cards rather than just showing them.
And the setting is always shown when autofill syncing is enabled, regardless of
whether the user already has cards in Payments.

BUG=535784

Committed: https://crrev.com/4b319fe9db26b7fb7fc9bb0ed00ae9717795438c
Cr-Commit-Position: refs/heads/master@{#369253}
==========

[commit-bot: I haz the power, 2016-01-13 20:11:35]

Patchset 3 (id:??) landed as
https://crrev.com/4b319fe9db26b7fb7fc9bb0ed00ae9717795438c
Cr-Commit-Position: refs/heads/master@{#369253}