Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: third_party/WebKit/LayoutTests/TestExpectations

Issue 1571833002: Add popup layout tests with device scale factor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations b/third_party/WebKit/LayoutTests/TestExpectations
index 86048507cb7b22eeb8c9aef9d2a65cfacd97cf65..ec096b02512933dbc1c0499ae9f96f90688190b6 100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1,6 +1,9 @@
# Run these tests with under virtual/spv2 only.
crbug.com/524134 paint/invalidation/spv2 [ Skip ]
+# Run these tests with under virtual/scalefactor... only.
+crbug.com/567837 fast/hidpi/static [ Skip ]
+
# TODO(yosin): We should convert following tests to use asynchronous spell checker.
crbug.com/563265 editing/spelling/context-menu-suggestions.html [ Skip ]
crbug.com/563265 editing/spelling/spellcheck-editable-on-focus-multiframe.html [ Skip ]
@@ -221,12 +224,13 @@ crbug.com/542541 [ Debug ] fast/events/click-count.html [ Pass Failure ]
crbug.com/542541 [ Debug ] virtual/trustedeventsdefaultaction/fast/events/click-count.html [ Pass Failure ]
crbug.com/542541 [ Debug ] virtual/pointerevent/fast/events/click-count.html [ Pass Failure ]
-# FIXME issue 570401, FIXME dsf2 is an abbrv, fix the test name per style.
-crbug.com/495750 fast/hidpi/calendar-picker-appearance-dsf2-with-zoom.html [ Skip ]
-crbug.com/495750 fast/hidpi/calendar-picker-appearance-dsf2.html [ Skip ]
-crbug.com/495750 fast/hidpi/data-suggestion-picker-appearance-dsf2-with-zoom.html [ Skip ]
-crbug.com/495750 fast/hidpi/data-suggestion-picker-appearance-dsf2.html [ Skip ]
-crbug.com/495750 fast/hidpi/popup-menu-appearance-dsf2-with-zoom.html [ Skip ]
+crbug.com/495750 [ Win Mac ] virtual/scalefactor200/fast/hidpi/static [ NeedsRebaseline ]
tkent 2016/01/11 23:55:53 Why only Win and Mac?
oshima 2016/01/12 00:12:22 I added images for linux in this CL. Let me know i
tkent 2016/01/12 00:16:22 I recommend to do rebaseline for all platforms eve
oshima 2016/01/12 01:39:43 done
+crbug.com/495750 [ Win Mac ] virtual/scalefactor150/fast/hidpi/static [ NeedsRebaseline ]
+crbug.com/495750 [ Win ] virtual/scalefactor200withzoom/fast/hidpi/static [ NeedsRebaseline ]
+crbug.com/495750 [ Mac ] virtual/scalefactor200withzoom/fast/hidpi/static [ Skip ]
tkent 2016/01/11 23:55:53 Why is this skipped on Mac?
oshima 2016/01/12 00:12:22 use-zoom-for-dsf isn't ready on mac yet.
tkent 2016/01/12 00:16:22 I see.
+# TODO(oshima): Fix the popup's size adjustmenet.
+crbug.com/495750 virtual/scalefactor200/fast/hidpi/static/data-suggestion-picker-appearance.html [ Skip ]
+crbug.com/495750 virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance.html [ Skip ]
# TODO(ojan): These tests aren't flaky. See crbug.com/517144.
# Release trybots run asserts, but the main waterfall ones don't. So, even
« no previous file with comments | « content/shell/renderer/layout_test/blink_test_runner.cc ('k') | third_party/WebKit/LayoutTests/VirtualTestSuites » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698