components/test_runner/web_test_proxy.cc - Issue 1571833002: Add popup layout tests with device scale factor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_test_proxy.cc

Issue 1571833002: Add popup layout tests with device scale factor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/test_runner/web_test_proxy.cc

diff --git a/components/test_runner/web_test_proxy.cc b/components/test_runner/web_test_proxy.cc

index 9cd2372263b0ac081f43db23b6c39bb4eb126844..76fa57052f5a7315482ac1cbdb4458b716291ac3 100644

--- a/components/test_runner/web_test_proxy.cc

+++ b/components/test_runner/web_test_proxy.cc

@@ -673,7 +673,8 @@ void WebTestProxyBase::CapturePixelsAsync(

web_widget_->compositeAndReadbackAsync(capture_callback);

if (blink::WebPagePopup* popup = web_widget_->pagePopup()) {

capture_callback->set_wait_for_popup(true);

- capture_callback->set_popup_position(popup->positionRelativeToOwner());

+ capture_callback->set_popup_position(

+ delegate_->ConvertDIPToNative(popup->positionRelativeToOwner()));

popup->compositeAndReadbackAsync(capture_callback);

}