Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1571833002: Add popup layout tests with device scale factor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index f7c4285b77c22af72246b67528f58d52ec246683..9adf3b9cf1aca63912c956c28ed8c73c80df71d8 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -769,6 +769,12 @@ void BlinkTestRunner::OnWebTestProxyBaseDestroy(
test_runner::WebTestProxyBase* proxy) {
}
+blink::WebPoint BlinkTestRunner::ConvertDIPToNative(
+ const blink::WebPoint& point_in_dip) const {
+ float scale = render_view()->GetDeviceScaleFactorForTest();
oshima 2016/01/08 22:27:56 FYI: I added new method to get scale factor becaus
Noel Gordon 2016/01/09 03:23:50 Add FIXME/TODO.
oshima 2016/01/11 18:52:12 This code won't change.
+ return blink::WebPoint(point_in_dip.x * scale,
+ point_in_dip.y * scale);
+}
oshima 2016/01/08 22:27:55 Spacing is fixed in the next patch.
bool BlinkTestRunner::AddMediaStreamVideoSourceAndTrack(
blink::WebMediaStream* stream) {
DCHECK(stream);

Powered by Google App Engine
This is Rietveld 408576698