Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: mojo/tools/get_test_list.py

Issue 1571823002: Dart: Adds tests of a couple Dart examples. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « examples/dart/wget/test/wget_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/tools/get_test_list.py
diff --git a/mojo/tools/get_test_list.py b/mojo/tools/get_test_list.py
index 53d93eca4cf387c25d83646b7871c79a601aa45b..9cddc16eec3598ab33d5271c3033b8b9dffe6c48 100755
--- a/mojo/tools/get_test_list.py
+++ b/mojo/tools/get_test_list.py
@@ -177,24 +177,30 @@ def GetTestList(config, verbose_count=0):
"--build-dir=" + build_dir,
"--dart-exe=third_party/dart-sdk/dart-sdk/bin/dart"])
- # Dart mojom package generate.dart script tests:
- if target_os == Config.OS_LINUX and ShouldRunTest(Config.TEST_TYPE_DEFAULT):
- AddEntry("Dart mojom package generate tests",
- [os.path.join("third_party", "dart-sdk", "dart-sdk", "bin", "dart"),
- "--checked",
- "-p", os.path.join(build_dir, "gen", "dart-pkg", "packages"),
- os.path.join(
- "mojo", "dart", "packages", "mojom", "test", "generate_test.dart")])
-
- if target_os == Config.OS_LINUX and ShouldRunTest(Config.TEST_TYPE_DEFAULT):
- AddEntry("Dart snapshotter test",
- ["python",
- os.path.join("mojo", "dart", "embedder", "snapshotter", "test",
- "dart_snapshotter_test.py"),
- "--build-dir=" + build_dir])
-
- # Dart analyzer test
- if ShouldRunTest(Config.TEST_TYPE_DEFAULT, "analyze-dart"):
Cutch 2016/01/11 22:17:24 This "analyze-dart" case needs to be kept for the
zra 2016/01/11 22:44:54 Oh, right. Sorry, I misunderstood your initial com
+ if ShouldRunTest(Config.TEST_TYPE_DEFAULT):
+ if target_os == Config.OS_LINUX:
+ # Dart mojom package generate.dart script tests:
+ AddEntry("Dart mojom package generate tests",
+ [os.path.join("third_party", "dart-sdk", "dart-sdk", "bin", "dart"),
+ "--checked",
+ "-p", os.path.join(build_dir, "gen", "dart-pkg", "packages"),
+ os.path.join(
+ "mojo", "dart", "packages", "mojom", "test",
+ "generate_test.dart")])
+
+ # Tests of Dart examples.
+ AddEntry("Dart examples tests",
+ ["python", os.path.join("examples", "dart", "example_tests.py"),
+ "--build-dir", build_dir])
+
+ # Test of Dart's snapshotter.
+ AddEntry("Dart snapshotter test",
+ ["python",
+ os.path.join("mojo", "dart", "embedder", "snapshotter", "test",
+ "dart_snapshotter_test.py"),
+ "--build-dir=" + build_dir])
+
+ # Dart analyzer test
AddEntry("Dart Package Static Analysis",
["python",
os.path.join("mojo", "public", "tools", "dart_pkg_static_analysis.py"),
« no previous file with comments | « examples/dart/wget/test/wget_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698