Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1571823002: Dart: Adds tests of a couple Dart examples. (Closed)

Created:
4 years, 11 months ago by zra
Modified:
4 years, 11 months ago
Reviewers:
Cutch
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Dart: Adds tests of a couple Dart examples. We should keep the examples under //examples/dart in a working state. R=johnmccutchan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/79a84f9d225bb428b3baf892b0a77c952a548141

Patch Set 1 #

Patch Set 2 : Fix path #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 4

Patch Set 8 : #

Patch Set 9 : #

Total comments: 2

Patch Set 10 : Restore analyze-dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -18 lines) Patch
A examples/dart/example_tests.py View 1 2 3 4 5 6 7 8 1 chunk +59 lines, -0 lines 0 comments Download
M examples/dart/hello_world/hello/lib/main.dart View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M examples/dart/hello_world/hello/pubspec.yaml View 1 chunk +9 lines, -0 lines 0 comments Download
A examples/dart/hello_world/hello/test/hello_test.dart View 1 2 3 4 5 6 1 chunk +72 lines, -0 lines 0 comments Download
M examples/dart/wget/pubspec.yaml View 1 chunk +8 lines, -2 lines 0 comments Download
A examples/dart/wget/test/wget_test.dart View 1 2 3 4 1 chunk +90 lines, -0 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 2 3 4 5 6 7 8 9 1 chunk +24 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
zra
4 years, 11 months ago (2016-01-11 21:03:21 UTC) #2
Cutch
https://codereview.chromium.org/1571823002/diff/120001/examples/dart/example_tests.py File examples/dart/example_tests.py (right): https://codereview.chromium.org/1571823002/diff/120001/examples/dart/example_tests.py#newcode22 examples/dart/example_tests.py:22: os.path.join('wget', 'test', 'wget_test.dart'), I'd prefer to just list the ...
4 years, 11 months ago (2016-01-11 21:10:59 UTC) #3
zra
https://codereview.chromium.org/1571823002/diff/120001/examples/dart/example_tests.py File examples/dart/example_tests.py (right): https://codereview.chromium.org/1571823002/diff/120001/examples/dart/example_tests.py#newcode22 examples/dart/example_tests.py:22: os.path.join('wget', 'test', 'wget_test.dart'), On 2016/01/11 21:10:58, Cutch wrote: > ...
4 years, 11 months ago (2016-01-11 22:11:18 UTC) #4
Cutch
LGTM after fixing: $ ./mojo/tools/mojob.py analyze-dart https://codereview.chromium.org/1571823002/diff/160001/mojo/tools/get_test_list.py File mojo/tools/get_test_list.py (left): https://codereview.chromium.org/1571823002/diff/160001/mojo/tools/get_test_list.py#oldcode197 mojo/tools/get_test_list.py:197: if ShouldRunTest(Config.TEST_TYPE_DEFAULT, "analyze-dart"): ...
4 years, 11 months ago (2016-01-11 22:17:24 UTC) #5
zra
https://codereview.chromium.org/1571823002/diff/160001/mojo/tools/get_test_list.py File mojo/tools/get_test_list.py (left): https://codereview.chromium.org/1571823002/diff/160001/mojo/tools/get_test_list.py#oldcode197 mojo/tools/get_test_list.py:197: if ShouldRunTest(Config.TEST_TYPE_DEFAULT, "analyze-dart"): On 2016/01/11 22:17:24, Cutch wrote: > ...
4 years, 11 months ago (2016-01-11 22:44:54 UTC) #6
zra
4 years, 11 months ago (2016-01-11 22:45:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #10 (id:170001) manually as
79a84f9d225bb428b3baf892b0a77c952a548141 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698