Issue 1571803002: [Android] Prepare build/android/ for catapult+devil.

Issue 1571803002: [Android] Prepare build/android/ for catapult+devil. (Closed)

Created:
4 years, 11 months ago by jbudorick

Modified:
4 years, 11 months ago

Reviewers:
mikecase (-- gone --), rnephew (Reviews Here), agrieve

CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, aiolos (Not reviewing)

Base URL:
https://chromium.googlesource.com/chromium/src.git@create-device-library-links

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Android] Prepare build/android/ for catapult+devil. BUG=476719 Committed: https://crrev.com/d28554a567ddb871196a9268c1d76d8a0061370b Cr-Commit-Position: refs/heads/master@{#368599}

Patch Set 3 : rebase #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+281 lines, -225 lines)			Patch
M	build/android/adb_command_line.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/android/adb_reverse_forwarder.py	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	build/android/android.isolate	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/android/asan_symbolize.py	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	build/android/avd.py	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
D	build/android/bb_run_sharded_steps.py	View		1 chunk	+0 lines, -41 lines	0 comments	Download
M	build/android/buildbot/bb_device_status_check.py	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	build/android/buildbot/bb_device_steps.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	build/android/buildbot/bb_host_steps.py	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	build/android/buildbot/bb_utils.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/android/devil_chromium.py	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	build/android/emma_coverage_stats.py	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	build/android/emma_coverage_stats_test.py	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	build/android/enable_asserts.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	build/android/findbugs_diff.py	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	build/android/generate_emma_html.py	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	build/android/gyp/create_device_library_links.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/gyp/java_google_api_keys.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	build/android/gyp/jinja_template.py	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	build/android/gyp/push_libraries.py	View		2 chunks	+10 lines, -7 lines	0 comments	Download
M	build/android/gyp/util/build_device.py	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	build/android/gyp/util/build_utils.py	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	build/android/host_heartbeat.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/android/incremental_install/create_install_script.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	build/android/install_emulator_deps.py	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	build/android/lint/suppress.py	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	build/android/method_count.py	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	build/android/play_services/preprocess.py	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	build/android/play_services/update.py	View		6 chunks	+8 lines, -5 lines	0 comments	Download
M	build/android/provision_devices.py	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	build/android/push_libraries.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
M	build/android/pylib/__init__.py	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	build/android/pylib/base/base_setup.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	build/android/pylib/base/test_dispatcher_unittest.py	View		4 chunks	+12 lines, -14 lines	0 comments	Download
M	build/android/pylib/chrome_test_server_spawner.py	View		3 chunks	+8 lines, -7 lines	0 comments	Download
A	build/android/pylib/constants/host_paths.py	View	1	1 chunk	+38 lines, -0 lines	0 comments	Download
M	build/android/pylib/gtest/gtest_test_instance.py	View	1	3 chunks	+5 lines, -6 lines	0 comments	Download
M	build/android/pylib/host_driven/test_info_collection.py	View	1	1 chunk	+3 lines, -8 lines	0 comments	Download
M	build/android/pylib/host_driven/test_server.py	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	build/android/pylib/instrumentation/instrumentation_test_instance.py	View	1	2 chunks	+4 lines, -5 lines	0 comments	Download
M	build/android/pylib/instrumentation/instrumentation_test_instance_test.py	View	1	1 chunk	+3 lines, -8 lines	0 comments	Download
M	build/android/pylib/instrumentation/setup.py	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	build/android/pylib/instrumentation/test_jar.py	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download
M	build/android/pylib/instrumentation/test_runner.py	View	1	3 chunks	+4 lines, -5 lines	0 comments	Download
M	build/android/pylib/linker/setup.py	View	1	1 chunk	+3 lines, -7 lines	0 comments	Download
M	build/android/pylib/perf/test_runner.py	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	build/android/pylib/remote/device/appurify_sanitized.py	View	1	1 chunk	+19 lines, -16 lines	0 comments	Download
M	build/android/pylib/results/flakiness_dashboard/results_uploader.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	build/android/pylib/utils/findbugs.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	build/android/pylib/utils/isolator.py	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	build/android/pylib/utils/logging_utils.py	View	1	1 chunk	+7 lines, -5 lines	0 comments	Download
M	build/android/resource_sizes.py	View	1	3 chunks	+12 lines, -7 lines	0 comments	Download
M	build/android/screenshot.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	build/android/symbolize.py	View	1	1 chunk	+5 lines, -6 lines	0 comments	Download
M	build/android/test_runner.py	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	build/android/tombstones.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	build/android/update_verification.py	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	build/android/video_recorder.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 14 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jbudorick

Note that, because //build/android/ precedes //third_party/catapult/devil/ in the sys.path, this doesn't switch anything over. Everything ...

4 years, 11 months ago (2016-01-08 20:27:38 UTC) #2

rnephew (Reviews Here)

long cl is long, lgtm with a question. https://codereview.chromium.org/1571803002/diff/20001/build/android/buildbot/bb_utils.py File build/android/buildbot/bb_utils.py (right): https://codereview.chromium.org/1571803002/diff/20001/build/android/buildbot/bb_utils.py#newcode20 build/android/buildbot/bb_utils.py:20: This ...

4 years, 11 months ago (2016-01-08 20:44:05 UTC) #3

jbudorick

https://codereview.chromium.org/1571803002/diff/20001/build/android/buildbot/bb_utils.py File build/android/buildbot/bb_utils.py (right): https://codereview.chromium.org/1571803002/diff/20001/build/android/buildbot/bb_utils.py#newcode20 build/android/buildbot/bb_utils.py:20: On 2016/01/08 20:44:05, rnephew1 wrote: > This one doesn't ...

4 years, 11 months ago (2016-01-08 20:46:49 UTC) #4

agrieve

https://codereview.chromium.org/1571803002/diff/20001/build/android/asan_symbolize.py File build/android/asan_symbolize.py (right): https://codereview.chromium.org/1571803002/diff/20001/build/android/asan_symbolize.py#newcode17 build/android/asan_symbolize.py:17: with host_paths.SysPath( nice https://codereview.chromium.org/1571803002/diff/20001/build/android/gyp/push_libraries.py File build/android/gyp/push_libraries.py (right): https://codereview.chromium.org/1571803002/diff/20001/build/android/gyp/push_libraries.py#newcode67 build/android/gyp/push_libraries.py:67: ...

4 years, 11 months ago (2016-01-08 21:04:03 UTC) #5

jbudorick

https://codereview.chromium.org/1571803002/diff/20001/build/android/gyp/push_libraries.py File build/android/gyp/push_libraries.py (right): https://codereview.chromium.org/1571803002/diff/20001/build/android/gyp/push_libraries.py#newcode67 build/android/gyp/push_libraries.py:67: parser.add_option('--output-directory', On 2016/01/08 21:04:03, agrieve wrote: > Need to ...

4 years, 11 months ago (2016-01-08 23:10:21 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571803002/40001

4 years, 11 months ago (2016-01-11 15:09:14 UTC) #11

commit-bot: I haz the power

4 years, 11 months ago (2016-01-11 16:23:56 UTC) #14

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/d28554a567ddb871196a9268c1d76d8a0061370b
Cr-Commit-Position: refs/heads/master@{#368599}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages