Add SessionStateObserver with ActiveUserChanged()

chrome/browser/ui/ash/session_state_delegate.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_ASH_SESSION_STATE_DELEGATE_H_
 #define CHROME_BROWSER_UI_ASH_SESSION_STATE_DELEGATE_H_
 
 #include "ash/session_state_delegate.h"
 #include "base/basictypes.h"
 #include "base/compiler_specific.h"
+#include "base/observer_list.h"
 
-class SessionStateDelegate : public ash::SessionStateDelegate {
+#if defined(OS_CHROMEOS)
+#include "chrome/browser/chromeos/login/user_manager.h"
+
+namespace chromeos {
+class User;

[bartfab (slow), 2013/06/03 09:00:06]

When overriding a method, the common pattern I have seen is to not include
additional headers or forward-declare classes needed by that method's arguments
only. Going by that, no need to forward-declare |User| here.

[Nikita (slow), 2013/06/03 09:21:28]

Done.

+}
+#endif
+
+class SessionStateDelegate
+    :
+#if defined(OS_CHROMEOS)
+    public chromeos::UserManager::UserSessionStateObserver,
+#endif
+    public ash::SessionStateDelegate {
  public:
   SessionStateDelegate();
   virtual ~SessionStateDelegate();
 
   // ash::SessionStateDelegate:
   virtual int GetMaximumNumberOfLoggedInUsers() const OVERRIDE;
   virtual int NumberOfLoggedInUsers() const OVERRIDE;
   virtual bool IsActiveUserSessionStarted() const OVERRIDE;
   virtual bool CanLockScreen() const OVERRIDE;
   virtual bool IsScreenLocked() const OVERRIDE;
   virtual void LockScreen() OVERRIDE;
   virtual void UnlockScreen() OVERRIDE;
   virtual const base::string16 GetUserDisplayName(
       ash::MultiProfileIndex index) const OVERRIDE;
   virtual const std::string GetUserEmail(
       ash::MultiProfileIndex index) const OVERRIDE;
   virtual const gfx::ImageSkia& GetUserImage(
       ash::MultiProfileIndex index) const OVERRIDE;
   virtual void GetLoggedInUsers(ash::UserEmailList* users) OVERRIDE;
   virtual void SwitchActiveUser(const std::string& email) OVERRIDE;
+  virtual void AddSessionStateObserver(
+      ash::SessionStateObserver* observer) OVERRIDE;
+  virtual void RemoveSessionStateObserver(
+      ash::SessionStateObserver* observer) OVERRIDE;
+
+#if defined(OS_CHROMEOS)
+  // UserManager::UserSessionStateObserver:
+  virtual void ActiveUserChanged(const chromeos::User* active_user) OVERRIDE;
+#endif
 
  private:
+  ObserverList<ash::SessionStateObserver> session_state_observer_list_;

[bartfab (slow), 2013/06/03 09:00:06]

Nit: The list is used in the Chrome OS implementation only. It should be
#ifdef'd to OS_CHROMEOS.

[Nikita (slow), 2013/06/03 09:21:28]

Actually SessionStateObserver is defined for everyone.
This might be later used for other platforms I just wanted to leave such option.

WDYT?

[bartfab (slow), 2013/06/03 09:26:52]

AddSessionStateObserver and RemoveSessionStateObserver are NOTREACHED() on
non-Chrome-OS platforms. Until we add support for adding and removing observers,
there is no need to allocate memory for an observer list IMHO. If you #ifdef the
observer list here, you can always later remove the #ifdefs when the observer
list becomes supported on other platforms.

[Nikita (slow), 2013/06/03 09:46:54]

Done.

+
   DISALLOW_COPY_AND_ASSIGN(SessionStateDelegate);
 };
 
 #endif  // CHROME_BROWSER_UI_ASH_SESSION_STATE_DELEGATE_H_