Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1571793002: Reland of Ship ES2015 sloppy-mode function hoisting, let, class (Closed)

Created:
4 years, 11 months ago by Dan Ehrenberg
Modified:
4 years, 11 months ago
Reviewers:
adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Ship ES2015 sloppy-mode function hoisting, let, class (patchset #1 id:1 of https://codereview.chromium.org/1565263002/ ) Reason for revert: Crash fixed by https://codereview.chromium.org/1564923007 Original issue's description: > Revert of Ship ES2015 sloppy-mode function hoisting, let, class (patchset #7 id:120001 of https://codereview.chromium.org/1551443002/ ) > > Reason for revert: > Causes frequent crashes in Canary: chromium:537816 > > Original issue's description: > > Ship ES2015 sloppy-mode function hoisting, let, class > > > > This patch doesn't ship all features of ES2015 variable/scoping > > changes, notably omitting the removal of legacy const. I think > > function hoisting, let and class in sloppy mode can stand to > > themselves as a package, and the legacy const change is much > > riskier and more likely to be reverted, so my intention is to > > pursue those as a separate, follow-on patch. > > > > R=adamk@chromium.org > > BUG=v8:4285, v8:3305 > > LOG=Y > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel > > > > Committed: https://crrev.com/fcff8588a5a01587643d6c2507c7b882c78a2957 > > Cr-Commit-Position: refs/heads/master@{#33133} > > TBR=adamk@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=v8:4285, v8:3305, chromium:537816 > LOG=Y > > Committed: https://crrev.com/adac5956c6216056a211cfaa460a00ac1500d8f8 > Cr-Commit-Position: refs/heads/master@{#33162} TBR=adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4285, v8:3305, chromium:537816 Committed: https://crrev.com/23235b5fdb5412355e826f7fc0c154c409b9be37 Cr-Commit-Position: refs/heads/master@{#33189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+367 lines, -351 lines) Patch
M src/flag-definitions.h View 2 chunks +4 lines, -4 lines 0 comments Download
M test/message/no-legacy-const.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/message/no-legacy-const.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/no-legacy-const-2.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/message/no-legacy-const-2.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/no-legacy-const-3.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/message/no-legacy-const-3.out View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/block-early-errors.js View 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/es6/block-eval-var-over-legacy-const.js View 1 chunk +84 lines, -0 lines 0 comments Download
A test/mjsunit/es6/block-let-contextual-sloppy.js View 1 chunk +66 lines, -0 lines 0 comments Download
M test/mjsunit/es6/block-non-strict-errors.js View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/es6/block-scope-class.js View 1 chunk +59 lines, -0 lines 0 comments Download
A test/mjsunit/es6/classes-derived-return-type.js View 1 chunk +90 lines, -0 lines 0 comments Download
D test/mjsunit/harmony/block-eval-var-over-legacy-const.js View 1 chunk +0 lines, -84 lines 0 comments Download
D test/mjsunit/harmony/block-let-contextual-sloppy.js View 1 chunk +0 lines, -66 lines 0 comments Download
D test/mjsunit/harmony/block-scope-class.js View 1 chunk +0 lines, -59 lines 0 comments Download
D test/mjsunit/harmony/classes-derived-return-type.js View 1 chunk +0 lines, -90 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 2 chunks +3 lines, -2 lines 0 comments Download
D test/mjsunit/harmony/regress/regress-crbug-451770.js View 1 chunk +0 lines, -15 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/regress/regress-91120.js View 1 chunk +11 lines, -9 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-323936.js View 2 chunks +5 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-451770.js View 1 chunk +15 lines, -0 lines 0 comments Download
M test/mozilla/mozilla.status View 2 chunks +3 lines, -10 lines 0 comments Download
M test/webkit/fast/js/kde/func-decl-expected.txt View 1 chunk +6 lines, -3 lines 0 comments Download
M test/webkit/webkit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Dan Ehrenberg
Created Reland of Ship ES2015 sloppy-mode function hoisting, let, class
4 years, 11 months ago (2016-01-08 17:34:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571793002/1
4 years, 11 months ago (2016-01-08 17:34:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-08 17:34:41 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/23235b5fdb5412355e826f7fc0c154c409b9be37 Cr-Commit-Position: refs/heads/master@{#33189}
4 years, 11 months ago (2016-01-08 17:35:09 UTC) #5
adamk
4 years, 11 months ago (2016-01-08 18:50:32 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698