Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1571713002: [wasm] s/NULL/nullptr/g (Closed)

Created:
4 years, 11 months ago by titzer
Modified:
4 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] s/NULL/nullptr/g R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/6395314086cc5e02781176a430da64b97bc56975 Cr-Commit-Position: refs/heads/master@{#33173}

Patch Set 1 #

Total comments: 3

Patch Set 2 : DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M src/wasm/asm-wasm-builder.cc View 13 chunks +19 lines, -19 lines 0 comments Download
M src/wasm/encoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/wasm/encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/wasm/wasm-js.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
titzer
4 years, 11 months ago (2016-01-08 12:08:59 UTC) #1
Michael Starzinger
https://codereview.chromium.org/1571713002/diff/1/src/wasm/ast-decoder.cc File src/wasm/ast-decoder.cc (right): https://codereview.chromium.org/1571713002/diff/1/src/wasm/ast-decoder.cc#newcode1127 src/wasm/ast-decoder.cc:1127: DCHECK_NOT_nullptr(to); Doesn't look right. https://codereview.chromium.org/1571713002/diff/1/src/wasm/ast-decoder.cc#newcode1244 src/wasm/ast-decoder.cc:1244: DCHECK_NOT_nullptr(from); Doesn't look ...
4 years, 11 months ago (2016-01-08 12:11:04 UTC) #2
titzer
On 2016/01/08 12:11:04, Michael Starzinger wrote: > https://codereview.chromium.org/1571713002/diff/1/src/wasm/ast-decoder.cc > File src/wasm/ast-decoder.cc (right): > > https://codereview.chromium.org/1571713002/diff/1/src/wasm/ast-decoder.cc#newcode1127 ...
4 years, 11 months ago (2016-01-08 12:11:34 UTC) #3
Michael Starzinger
LGTM.
4 years, 11 months ago (2016-01-08 12:12:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571713002/20001
4 years, 11 months ago (2016-01-08 12:15:07 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 12:44:20 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 12:45:17 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6395314086cc5e02781176a430da64b97bc56975
Cr-Commit-Position: refs/heads/master@{#33173}

Powered by Google App Engine
This is Rietveld 408576698