Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1571673002: [not for landing] Re-shuffle AllocationSite members (Closed)

Created:
4 years, 11 months ago by Michael Lippautz
Modified:
4 years, 8 months ago
Reviewers:
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@rebased-scratchpad
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cannot land this because we did not get rid of memento found counts on allocation sites. Re-shuffle AllocationSite members Since we got rid of the memento found counter on the AllocationSite in [1] we can use the freed up space for the memento created counter, effectively saving a word per AllocationSite. [1] https://codereview.chromium.org/1535723002/ BUG=chromium:524425 LOG=N

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -27 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.h View 3 chunks +2 lines, -5 lines 0 comments Download
M src/objects-inl.h View 3 chunks +6 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (10 generated)
Michael Lippautz
Description was changed from ========== [crankshaft] Re-shuffle AllocationSite members Since we got rid of the ...
4 years, 11 months ago (2016-01-08 08:25:18 UTC) #1
Michael Lippautz
Description was changed from ========== [crankshaft] Re-shuffle AllocationSite members Since we got rid of the ...
4 years, 11 months ago (2016-01-08 08:25:38 UTC) #2
Michael Lippautz
Patchset #1 (id:1) has been deleted
4 years, 11 months ago (2016-01-08 08:27:46 UTC) #3
Michael Lippautz
Description was changed from ========== Re-shuffle AllocationSite members Since we got rid of the memento ...
4 years, 11 months ago (2016-01-08 08:29:37 UTC) #4
Michael Lippautz
Description was changed from ========== Re-shuffle AllocationSite members Since we got rid of the memento ...
4 years, 11 months ago (2016-01-08 08:29:53 UTC) #5
Michael Lippautz
Description was changed from ========== Re-shuffle AllocationSite members Since we got rid of the memento ...
4 years, 11 months ago (2016-01-08 08:30:02 UTC) #6
Michael Lippautz
Description was changed from ========== Re-shuffle AllocationSite members Since we got rid of the memento ...
4 years, 11 months ago (2016-01-08 08:30:27 UTC) #7
Michael Lippautz
Description was changed from ========== Re-shuffle AllocationSite members Since we got rid of the memento ...
4 years, 11 months ago (2016-01-08 13:33:45 UTC) #8
Michael Lippautz
Description was changed from ========== Re-shuffle AllocationSite members Since we got rid of the memento ...
4 years, 11 months ago (2016-01-11 10:34:42 UTC) #9
Michael Lippautz
4 years, 11 months ago (2016-01-13 08:25:08 UTC) #10
Description was changed from

==========
Re-shuffle AllocationSite members

Since we got rid of the memento found counter on the AllocationSite in [1] we
can use the freed up space for the memento created counter, effectively saving a
word per AllocationSite.

[1] https://codereview.chromium.org/1535723002/

BUG=chromium:524425
LOG=N
==========

to

==========
Cannot land this because we did not get rid of memento
found counts on allocation sites.

Re-shuffle AllocationSite members

Since we got rid of the memento found counter on the AllocationSite in [1] we
can use the freed up space for the memento created counter, effectively saving a
word per AllocationSite.

[1] https://codereview.chromium.org/1535723002/

BUG=chromium:524425
LOG=N
==========

Powered by Google App Engine
This is Rietveld 408576698