Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: base/json/json_parser.h

Issue 1571633002: Pass Manifest JSON paser error line and column number to console. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/json/json_parser.cc » ('j') | base/json/json_reader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_parser.h
diff --git a/base/json/json_parser.h b/base/json/json_parser.h
index 57c07ba10aaf5f36c51c1ee51362e79e5658d6d2..6d6ca6fa282073bb8887155a889ad68929c29baa 100644
--- a/base/json/json_parser.h
+++ b/base/json/json_parser.h
@@ -58,6 +58,9 @@ class BASE_EXPORT JSONParser {
// Returns the human-friendly error message.
std::string GetErrorMessage() const;
+ int error_line() const;
Nico 2016/01/13 20:50:39 Add a comment that explains when these return vali
horo 2016/01/14 02:25:45 Done.
+ int error_column() const;
Nico 2016/01/13 20:50:39 There's so much error data here now -- does it mak
horo 2016/01/14 02:25:45 That sound good. I will create another CL.
+
private:
enum Token {
T_OBJECT_BEGIN, // {
« no previous file with comments | « no previous file | base/json/json_parser.cc » ('j') | base/json/json_reader.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698