Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1571603003: Move atomicinc in GrTracing to behind branch (Closed)

Created:
4 years, 11 months ago by joshua.litt
Modified:
4 years, 11 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : updated #

Patch Set 3 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -68 lines) Patch
M include/gpu/GrCaps.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M include/gpu/GrConfig.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/GrTracing.h View 1 2 1 chunk +40 lines, -56 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
joshualitt
Thoughts?
4 years, 11 months ago (2016-01-08 16:49:11 UTC) #3
egdaniel
lgtm with caps cleanup https://codereview.chromium.org/1571603003/diff/1/include/gpu/GrConfig.h File include/gpu/GrConfig.h (left): https://codereview.chromium.org/1571603003/diff/1/include/gpu/GrConfig.h#oldcode192 include/gpu/GrConfig.h:192: #if !defined(GR_FORCE_GPU_TRACE_DEBUGGING) this is also ...
4 years, 11 months ago (2016-01-08 17:00:39 UTC) #4
joshualitt
On 2016/01/08 17:00:39, egdaniel wrote: > lgtm with caps cleanup > > https://codereview.chromium.org/1571603003/diff/1/include/gpu/GrConfig.h > File ...
4 years, 11 months ago (2016-01-08 19:28:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571603003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571603003/20001
4 years, 11 months ago (2016-01-11 14:20:09 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/5199)
4 years, 11 months ago (2016-01-11 14:21:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571603003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571603003/40001
4 years, 11 months ago (2016-01-11 16:07:11 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571603003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571603003/40001
4 years, 11 months ago (2016-01-11 16:24:10 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 16:30:50 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4897ff20fc68242d8a3469721f381f03987a0723

Powered by Google App Engine
This is Rietveld 408576698