Add a Preference for Google Services to Use the User's Location

chrome/browser/ui/webui/options/content_settings_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/content_settings_handler.h"
 
 #include <map>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 280 matching lines @@
     { "cookies_header", IDS_COOKIES_HEADER },
     { "cookies_allow", IDS_COOKIES_ALLOW_RADIO },
     { "cookies_block", IDS_COOKIES_BLOCK_RADIO },
     { "cookies_session_only", IDS_COOKIES_SESSION_ONLY_RADIO },
     { "cookies_block_3rd_party", IDS_COOKIES_BLOCK_3RDPARTY_CHKBOX },
     { "cookies_clear_when_close", IDS_COOKIES_CLEAR_WHEN_CLOSE_CHKBOX },
     { "cookies_lso_clear_when_close", IDS_COOKIES_LSO_CLEAR_WHEN_CLOSE_CHKBOX },
     { "cookies_show_cookies", IDS_COOKIES_SHOW_COOKIES_BUTTON },
     { "flash_storage_settings", IDS_FLASH_STORAGE_SETTINGS },
     { "flash_storage_url", IDS_FLASH_STORAGE_URL },
+#if defined(ENABLE_GOOGLE_NOW)
+    { "googleGeolocationAccessEnable",
+       IDS_GEOLOCATION_GOOGLE_ACCESS_ENABLE },

[vadimt, 2013/06/07 19:13:44]

Should end with _CHKBOX like IDS_COOKIES_LSO_CLEAR_WHEN_CLOSE_CHKBOX?

[robliao, 2013/06/07 20:03:59]

A lot of the checks strings in the setting page do not end in _CHKBOX. Is there
a style guideline for this?
On 2013/06/07 19:13:44, vadimt wrote:

[robliao, 2013/06/07 20:04:52]

*checkbox strings
On 2013/06/07 20:03:59, Robert Liao wrote:

[vadimt, 2013/06/07 20:14:39]

In the name of consistency with the rest of this file?

[robliao, 2013/06/07 20:18:07]

Ah, I see. Going forward, it seems like we should strip out all of these
annotations.

If I change a checkbox to a radio button, I don't want to have to change all of
the constant names.

This changelist will have an appended annotation.

On 2013/06/07 20:14:39, vadimt wrote:

+#endif
     // Image filter.
     { "images_tab_label", IDS_IMAGES_TAB_LABEL },
     { "images_header", IDS_IMAGES_HEADER },
     { "images_allow", IDS_IMAGES_LOAD_RADIO },
     { "images_block", IDS_IMAGES_NOLOAD_RADIO },
     // JavaScript filter.
     { "javascript_tab_label", IDS_JAVASCRIPT_TAB_LABEL },
     { "javascript_header", IDS_JAVASCRIPT_HEADER },
     { "javascript_allow", IDS_JS_ALLOW_RADIO },
     { "javascript_block", IDS_JS_DONOTALLOW_RADIO },
@@ skipping 1074 matching lines @@
             media_settings_.flash_default_setting,
             media_settings_.flash_exceptions,
             media_settings_.policy_disable_audio,
             media_settings_.policy_disable_video)) {
       ShowFlashMediaLink(EXCEPTIONS, true);
     }
   }
 }
 
 }  // namespace options