Add a Preference for Google Services to Use the User's Location

chrome/browser/profiles/profile.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile.h"
 
 #include <string>
 
 #include "base/prefs/pref_service.h"
 #include "build/build_config.h"
@@ skipping 64 matching lines @@
       true,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterBooleanPref(
       prefs::kSafeBrowsingReportingEnabled,
       false,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterBooleanPref(
       prefs::kSafeBrowsingProceedAnywayDisabled,
       false,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterBooleanPref(

[vadimt, 2013/06/07 00:56:07]

#ifdef?

[robliao, 2013/06/07 07:34:36]

Done.

+      prefs::kComponentGeolocationEnabled,

[vadimt, 2013/06/07 00:56:07]

Why do we have the 'Component' part of the name?

[robliao, 2013/06/07 07:34:36]

This is to distinguish it from kGeolocationEnabled, which applies to webpage
content.
On 2013/06/07 00:56:07, vadimt wrote:

[robliao, 2013/06/07 07:34:36]

Done.

[vadimt, 2013/06/07 17:16:28]

I see. But 'Component' implies component extension, right?
I future, other services, may be including C++ ones, may use this flag too. How
about AccessGeolocation?

[robliao, 2013/06/07 18:35:38]

Changed to kGoogleGeolocationAccessEnabled
On 2013/06/07 17:16:28, vadimt wrote:

+      false,
+      user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
+  registry->RegisterBooleanPref(
       prefs::kDisableExtensions,
       false,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterBooleanPref(
       prefs::kExtensionAlertsInitializedPref,
       false,
       user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
   registry->RegisterStringPref(
       prefs::kSelectFileLastDirectory,
       std::string(),
@@ skipping 87 matching lines @@
 
 void Profile::MaybeSendDestroyedNotification() {
   if (!sent_destroyed_notification_) {
     sent_destroyed_notification_ = true;
     content::NotificationService::current()->Notify(
         chrome::NOTIFICATION_PROFILE_DESTROYED,
         content::Source<Profile>(this),
         content::NotificationService::NoDetails());
   }
 }