Split webkit_storage target into webkit_storage_{browser,common,renderer}

webkit/common/fileapi/file_system_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/common/fileapi/file_system_util.h"
 
 #include <algorithm>
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "googleurl/src/gurl.h"
 #include "webkit/base/origin_url_conversions.h"
 
 namespace fileapi {
 
-const char kPersistentDir[] = "/persistent";
-const char kTemporaryDir[] = "/temporary";
-const char kIsolatedDir[] = "/isolated";
-const char kExternalDir[] = "/external";
-const char kTestDir[] = "/test";
+const char* kPersistentDir = "/persistent";

[jamesr, 2013/06/10 22:07:21]

this seems like a slight change for the worse - if you want to change the [] to
* then you should add another level of 'const', but imo the [] version is a
shorter way of expressing the level of const-ness

+const char* kTemporaryDir = "/temporary";
+const char* kIsolatedDir = "/isolated";
+const char* kExternalDir = "/external";
+const char* kTestDir = "/test";
 
 const base::FilePath::CharType VirtualPath::kRoot[] = FILE_PATH_LITERAL("/");
 const base::FilePath::CharType VirtualPath::kSeparator = FILE_PATH_LITERAL('/');
 
 // TODO(ericu): Consider removing support for '\', even on Windows, if possible.
 // There's a lot of test code that will need reworking, and we may have trouble
 // with base::FilePath elsewhere [e.g. DirName and other methods may also need
 // replacement].
 base::FilePath VirtualPath::BaseName(const base::FilePath& virtual_path) {
   base::FilePath::StringType path = virtual_path.value();
@@ skipping 329 matching lines @@
   std::string root = GetFileSystemRootURI(origin_url,
                                           kFileSystemTypeExternal).spec();
   if (base::FilePath::FromUTF8Unsafe(mount_name).ReferencesParent())
     return std::string();
   root.append(mount_name);
   root.append("/");
   return root;
 }
 
 }  // namespace fileapi